You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
2f27744 fix: typo: add missing whitespace (UdjinM6)
732ef96 fix: typo: B in PSBT is Blockchain in our codebase (UdjinM6)
5205b61 fix: wrap the whole text in a global span to control its styling properly (UdjinM6)
01f74a2 fix: close "review transaction" span tag (UdjinM6)
Pull request description:
## Issue being fixed or feature implemented
b11d4e1 (#6853) broke styling in SendCoinsDialog (all text is smaller now).
develop (using CJ tx as an example to make most of text visible)
<img width="420" height="417" alt="Screenshot 2025-10-01 at 20 37 49" src="https://github.com/user-attachments/assets/9257708d-593b-465d-9237-a834989c52e5" />
before b11d4e1 (#6853)
<img width="419" height="440" alt="Screenshot 2025-10-01 at 20 25 55" src="https://github.com/user-attachments/assets/b53fb34c-e0d7-4b2e-8c2f-bf95a25a16cc" />
## What was done?
Fixed styling and also fixed some typos while at it. It looks like this now.
<img width="418" height="456" alt="Screenshot 2025-10-01 at 23 48 55" src="https://github.com/user-attachments/assets/16282519-a3c3-424e-adab-25b29a4d28a3" />
## How Has This Been Tested?
Run dash-qt and try sending regular and CJ txes to one/many recipients.
## Breaking Changes
n/a
## Checklist:
- [ ] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added or updated relevant unit/integration/functional/e2e tests
- [ ] I have made corresponding changes to the documentation
- [ ] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_
ACKs for top commit:
knst:
utACK 2f27744
kwvg:
utACK 2f27744
Tree-SHA512: 8642f80c6abd6850514fdec9f85bf38dc9e5ec903ad6c70827779a274e50d0f88288706087d560d6141f799c8891c18c3b57ff4dc80fa6898c6da7246b0f0b60
/*: Text to inform a user attempting to create a transaction of their current options. At this stage,
374
377
a user can only create a PSBT. This string is displayed when private keys are disabled and an external
375
378
signer is not available. */
376
-
question_string.append(tr("Please, review your transaction proposal. This will produce a Partially Signed Bitcoin Transaction (PSBT) which you can save or copy and then sign with e.g. an offline %1 wallet, or a PSBT-compatible hardware wallet.").arg(PACKAGE_NAME));
379
+
question_string.append(tr("Please, review your transaction proposal. This will produce a Partially Signed Blockchain Transaction (PSBT) which you can save or copy and then sign with e.g. an offline %1 wallet, or a PSBT-compatible hardware wallet.").arg(PACKAGE_NAME));
/*: Text to inform a user attempting to create a transaction of their current options. At this stage,
379
382
a user can send their transaction or create a PSBT. This string is displayed when both private keys
380
383
and PSBT controls are enabled. */
381
-
question_string.append(tr("Please, review your transaction. You can create and send this transaction or create a Partially Signed Bitcoin Transaction (PSBT), which you can save or copy and then sign with, e.g., an offline %1 wallet, or a PSBT-compatible hardware wallet.").arg(PACKAGE_NAME));
384
+
question_string.append(tr("Please, review your transaction. You can create and send this transaction or create a Partially Signed Blockchain Transaction (PSBT), which you can save or copy and then sign with, e.g., an offline %1 wallet, or a PSBT-compatible hardware wallet.").arg(PACKAGE_NAME));
382
385
} else {
383
386
/*: Text to prompt a user to review the details of the transaction they are attempting to send. */
384
387
question_string.append(tr("Please, review your transaction."));
0 commit comments