-
Notifications
You must be signed in to change notification settings - Fork 1.2k
test: functional tests for RPC debug #6612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request introduces modifications related to debug logging within the RPC framework. In 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (10)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
PastaPastaPasta
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 53000e1
kwvg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 53000e1
Issue being fixed or feature implemented
See https://github.com/dashpay/dash-issues/issues/63
What was done?
Functional tests for RPC
debug. Extended help for this RPC (mentioning of RPClogging)This PR replaces #6480
Lately I noticed that it's not trivial to use
loggingwith more than 1 category such aslogging [a, b]due to requirement to escape quotes, inside quotes whiledebug a+bdoesn't require any escaping and easier to type.How Has This Been Tested?
Run unit / functional tests (by CI)
Breaking Changes
N/A
Checklist: