-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: deprecate RPC 'debug' to favor of 'logging' #6480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
also, should be draft for now to avoid merging before v22.1 |
This failure will be fixed by merging PR after #6482 (removing this functional test) I will rebase it when v23 will be close enough |
|
@shumkov we are planning to remove If you are using command line option |
|
Superseeded by #6612
|
you could simply use |
53000e1 chore: use quotes for CLI example for rpc logging (Konstantin Akimov) 1f0f463 docs: extend doc for rpc 'debug' to mention rpc 'logging' (Konstantin Akimov) 07fefb3 tests: add functional tests for RPC debug (Konstantin Akimov) Pull request description: ## Issue being fixed or feature implemented See dashpay/dash-issues#63 ## What was done? Functional tests for RPC `debug`. Extended help for this RPC (mentioning of RPC `logging`) This PR replaces #6480 Lately I noticed that it's not trivial to use `logging` with more than 1 category such as `logging [a, b]` due to requirement to escape quotes, inside quotes while `debug a+b` doesn't require any escaping and easier to type. ## How Has This Been Tested? Run unit / functional tests (by CI) ``` test/functional/test_runner.py -j20 --previous-releases --coverage --extended ``` ## Breaking Changes N/A ## Checklist: - [x] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added or updated relevant unit/integration/functional/e2e tests - [ ] I have made corresponding changes to the documentation - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK 53000e1 kwvg: utACK 53000e1 Tree-SHA512: 4944b9b0476600ee993c25149eb18da485c6817fdffbe242f950dbbff16bc5ecd5ed9ad09935ffd00439c0d248a1b8b87504895faf33debf916eb4e714104e8f
Issue being fixed or feature implemented
The rpc
debugduplicates functionality of RPClogging.Beside that it has next disadvantages:
debugdoesn't have any testsdebughas our own implementation whileloggingis supported by mainstreamloggingcan work in both modes "all except..." and "only ...", whiledebugdoesn't have a feature "all except..."Though, there's particular case when
debugis more convenient: if you have several categories it's simplier to writedebug X+Yrather thanlogging "[\"X\", \"Y\"]"Discovered while doing https://github.com/dashpay/dash-issues/issues/63
What was done?
Deprecated rpc
debug.There's some HowTo for
debugusers for smooth switch tologging:For
debug all:logging [\"all\"]For
debug none:logging '[]' '["all"]'For
debug X+Y:logging "[\"X\", \"Y\"]"How Has This Been Tested?
Run unit and functional tests
Breaking Changes
It removes RPC
debugChecklist: