fix: ReconnectionInfo should also store Dash-specific flags

[UdjinM6]

Issue being fixed or feature implemented

Mixing with p2p v2 protocol enabled on p2p v1 masternodes triggers reconnection which "forgets" about Dash-specific flags so these connections aren't dropped on mixing session timeouts like they should. Most nodes on testnet are upgraded so the issue wasn't noticeable there unfortunately.

What was done?

Store Dash-specific flags in ReconnectionInfo and use them in PerformReconnections() later

How Has This Been Tested?

Breaking Changes

n/a

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[coderabbitai]

Walkthrough

The changes update the network connection management by modifying function signatures and data structures related to connection handling. In the network connection manager, methods such as OpenNetworkConnection, PerformReconnections, and DisconnectNodes have been updated to include two new parameters that differentiate between regular connections and those intended for masternodes and probes. A new method, OpenMasternodeConnection, has also been introduced to specifically manage masternode connections. Additionally, the ReconnectionInfo structure in the header file has been expanded with two boolean fields to track whether a connection is for a masternode or a probe. These adjustments allow the system to manage and monitor specialized connection types within the application.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b115fc7 and 17f0aa3.

📒 Files selected for processing (2)

• src/net.cpp (2 hunks)
• src/net.h (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: Build Image

🔇 Additional comments (3)

src/net.cpp (1)

2250-2253: Forces v1 fallback with consistent masternode settings.

These lines correctly preserve the masternode-related flags and set use_v2transport to false when reconnecting via v1. This ensures that:

• The same masternode flags (masternode_connection, masternode_probe_connection) are copied from the preceding connection.
• Future attempts will bypass v2 transport, avoiding repeated handshakes with a peer that might not have compatible v2 support.

src/net.h (2)

1977-1986: LGTM! The new fields will help retain masternode connection states during reconnections.

The addition of masternode_connection and masternode_probe_connection fields to the ReconnectionInfo struct aligns with the PR objective and follows consistent naming with similar fields in the CNode class.

---

1991-1991: LGTM! The list is properly protected for thread-safe reconnection queuing.

The m_reconnections list is appropriately guarded by a mutex and well-documented.

✨ Finishing Touches

• 📝 Generate Docstrings (Beta)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[kxcd]

Will this solve my problem with not being able to mix with any V2 MN? Currently my 22.1 client connects to such MNs and after about 30 seconds the connection is dropped. This happens during mixing. The error appears to be,

2025-02-12T12:14:38Z [mixing] DSCOMPLETE -- message doesn't match current Masternode: infoMixingMasternode=82.211.25.170:9999  addr=85.209.241.23:9999

I see lots of these just before the node is kicked.

[UdjinM6]

@kxcd No, this fixes another issue.

Will this solve my problem with not being able to mix with any V2 MN? Currently my 22.1 client connects to such MNs and after about 30 seconds the connection is dropped.

This is expected to happen if there is no mixing progress being made on that masternode.

This happens during mixing. The error appears to be,

2025-02-12T12:14:38Z [mixing] DSCOMPLETE -- message doesn't match current Masternode: infoMixingMasternode=82.211.25.170:9999  addr=85.209.241.23:9999

I see lots of these just before the node is kicked.

This is not an error actually, it's just an indication that this specific dsc message is not meant to be processed by that specific mixing session. It's going to be processed by the session that has the right address.

[kwvg]

ACK 17f0aa3

---

Tested by funding new wallet and mixing ~1 tDASH

[PastaPastaPasta]

utACK 17f0aa3

[knst]

LGTM 17f0aa3