[v0.16.x] Backport pending PRs #3670
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g governance validation (dashpay#3488) * enable privatesend by default in litemode Signed-off-by: Pasta <pasta@dashboost.org> * remove useless litemode check in CPrivateSendServer::ProcessMessage, must be MN, so must have litemode off already Signed-off-by: Pasta <pasta@dashboost.org> * change litemode to mean, doesn't validate governance, but has all other dash features Signed-off-by: Pasta <pasta@dashboost.org> * litemode must be off for MNs cont Signed-off-by: Pasta <pasta@dashboost.org> * change litemode help text Signed-off-by: Pasta <pasta@dashboost.org> * don't skip MN sync in litemode Signed-off-by: Pasta <pasta@dashboost.org> * drop fLiteMode in bitcoingui.cpp Signed-off-by: Pasta <pasta@dashboost.org> * skip governance sync in litemode Signed-off-by: pasta <pasta@dashboost.org> * remove fLiteMode in walletview.cpp Signed-off-by: pasta <pasta@dashboost.org> * add back Signed-off-by: pasta <pasta@dashboost.org> * fix comments * fix cache loading * fix scheduled tasks * Fix help text for some rpcs (revert what's left of 3478) Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
* Change litemode to disablegovernance, this makes it more clear what that flag actually does. Signed-off-by: pasta <pasta@dashboost.org> * more fLiteMode to fDisableGovernance Signed-off-by: pasta <pasta@dashboost.org> * handle -litemode being set Signed-off-by: pasta <pasta@dashboost.org>
* explicitly check that -disablegovernance is true for pruned mode. Signed-off-by: pasta <pasta@dashboost.org> * try to set -disablegovernance and -txindex if pruned mode is enabled Signed-off-by: pasta <pasta@dashboost.org> * Adjust InitWarning when governance validation is disabled Signed-off-by: pasta <pasta@dashboost.org> * Check for deprecated -litemode earlier * Move -disablegovernance warning into AppInitParameterInteraction * Tweak -prune help text and a related comment in AppInitParameterInteraction * Ignore init warnings in blockchain.py * Adjust "governance validation disabled" warning depending on if running a pruned node Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com> * Skip init warnings in import-rescan.py and node_network_limited.py Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
* More accurate fee calculation in CreateDenominated * Apply suggestions from code review Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> * Fix `finished` conditions Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
…dashpay#3589) This also means less smaller denoms (which could be good for privacy) and fixes a bug (not mixing all the available funds), see comments in code for more info.
dashpay#3592) ea65182 [wallet] loadwallet shouldn't create new wallets. (John Newbery) Pull request description: A bug in the initial implementation of loadwallet meant that if the arguement was a directory that didn't contain a wallet.dat file, a new wallet would be created in that directory. Fix that so that if a directory is passed in, it must contain a wallet.dat file. Bug reported by promag (João Barbosa). Tree-SHA512: 0a59fa8a33fde51a88544ad288b00e4995284fe16424f643076aaba42b8244fff362145217650ee53d518dfab7efbed4237632c34cdd3dcbbecaa9ecaab5fd7b Co-authored-by: MarcoFalke <falke.marco@gmail.com>
dashpay#3601) * llqm: Fix thread handling in CDKGSessionManager and CDKGSessionHandler * llmq: Removed unused thread_pool from CDKGSessionManager * Tweak `CDKGSessionHandler::StartThread()` * llmq: Simplify CDKGSessionHandler's thread naming * llmq: Make sure CDKGSessionHandler uses a valid LLMQ type Co-Authored-By: UdjinM6 <UdjinM6@users.noreply.github.com> Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
…ex (dashpay#3606) This indicates a previous crash where the TX made it into the txindex but the block was not flushed to disk. When dashd is restarted then, there is a short time where GetTransaction would return a non-existant block, while callers very often assume that the returned block hash is known.
…string" (dashpay#3609) Having "const char*" leads to undefined behaviour if the "const char*" is deallocated before the thread used it. Co-Authored-By: UdjinM6 <UdjinM6@users.noreply.github.com> Co-authored-by: UdjinM6 <UdjinM6@users.noreply.github.com>
* Add spork to change max mixing participants to 20 Signed-off-by: pasta <pasta@dashboost.org> * Also change min participants on devnet/testnet Signed-off-by: pasta <pasta@dashboost.org> * adjust formatting Signed-off-by: pasta <pasta@dashboost.org> * add nPoolNewMinParticipants under regtest Signed-off-by: pasta <pasta@dashboost.org>
…ashpay#3626) * init: Fix `-litemode` crash due to not connected CClientUIInterface signal Prior to this commit the signal `CClientUIInterface::ThreadSafeMessageBox` is not connected to a slot in Qt at the time its emitted when `-litemode` is used. The signal gets emitted from `InitWarning`, in `InitParameterInteraction`. This happens currently before `BitcoinGUI` gets created by `app.createWindow(networkStyle.data())` in `dash.cpp` where the signal becomes connected to the slot. After this commit the litemode `InitWarning` will be called in `AppInitParameterInteraction` which runs after `BitcoinGUI` has been created, means the signal will be connected then at that point and the crash is fixed. * init: Improve -litemode deprecation warning - Always show a basic warning if `-litemode` gets used no matter if its activated or not. - Let the user know when -disablegovernance gets forced by -litemode.
* Update rpcevo.cpp I would like to mirror docs.dash.org/en/stable/masternodes/maintenance.html#proupservtx by adding the specific term "BLS" to the rpc help menu to differentiate this is not a dash address key like the other ownerkey votingkey. We had this changed on the docs site to help clarify for people who were missing the point this was the operator BLS key. * Update rpcevo.cpp
* Include protocol version into MNAUTH * Introduce MNAUTH_NODE_VER_VERSION = 70218
…pay#3650) It seems like the idea here was to avoid announcing already available sigshares for a signhash to everyone if concentrated recovery is enabled. But by returning there if `IsAllMembersConnectedEnabled` equals to `false` we disable the re-announcements prior to the spork activation, where we want to still have them and re-enable if the spork is enabled where we don't want to have them.
* Implement a safer version of GetCrashInfoFromException `abi::__cxa_current_exception_type()` can return `null`, handle this properly * Update src/stacktraces.cpp Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> * Update src/stacktraces.cpp Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
* Print exception origin in crash messages We use `PrintExceptionContinue` in many places and we pass crash origin to it as a param but we never use it. Also, change the param name to better match its meaning. * Update src/util.cpp Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com> Co-authored-by: dustinface <35775977+xdustinface@users.noreply.github.com>
This was referenced Sep 8, 2020
Merged
This was referenced Sep 8, 2020
Merged
|
backport tag now removed from all merged PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I excluded a couple of PRs that didn't merge cleanly. All of these had no conflicts