Fail GetTransaction when the block from txindex is not in mapBlockIndex #3606
Conversation
This indicates a previous crash where the TX made it into the txindex but the block was not flushed to disk. When dashd is restarted then, there is a short time where GetTransaction would return a non-existant block, while callers very often assume that the returned block hash is known.
|
@xdustinface I obseved this while someone from the community was doing stress tests on testnet. Many of my nodes crashed due to OOM (I didn't reserve enough RAM per tMN) and then failed to start again, as they immediately received IS locks from other nodes which made them crash in IS code (here). Instead, the IS locks should have been handled as if the TX was unknown locally. |
@codablock thanks! So if i got it right it this means we have inconsistencies between the block data and the txindex if this happens? Is this at least resolved somehow later(probably when the block gets added properly again)? :D Also, could we prevent this by moving the txindex batch write from |
|
@xdustinface Yes we have inconsistencies in the case of a crash, but we can ignore them (with this patch applied) as the only place where the index is read is in |
|
@codablock alright. Means we should keep an eye on the future usage of |
…ex (dashpay#3606) This indicates a previous crash where the TX made it into the txindex but the block was not flushed to disk. When dashd is restarted then, there is a short time where GetTransaction would return a non-existant block, while callers very often assume that the returned block hash is known.
|
backported in #3670 |
…ex (dashpay#3606) This indicates a previous crash where the TX made it into the txindex but the block was not flushed to disk. When dashd is restarted then, there is a short time where GetTransaction would return a non-existant block, while callers very often assume that the returned block hash is known.
4 participants
This indicates a previous crash where the TX made it into the txindex but
the block was not flushed to disk. When dashd is restarted then, there is
a short time where GetTransaction would return a non-existant block, while
callers very often assume that the returned block hash is known.