-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Speed up integration tests with masternodes #2642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9c3f264 to
059fba8
Compare
UdjinM6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good (let's see if travis thinks so too :)) but I wonder if we could just tweak regtest params globally (in chainparams.cpp) and reuse cache (setup_clean_chain == False) instead of reimplementing data copy etc.
Co-Authored-By: codablock <ablock84@gmail.com>
UdjinM6
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
|
Some stats from my local machine. Before: ( After: 👍 |
See individual commits. Most speedup comes from reducing the number of blocks required to activate DIP3 and from copying the datadir of the first node to all other masternodes, which reduces initial sync time.
This PR currently also includes #2641 which I'll remove after merge.