Skip to content

Conversation

@codablock
Copy link

See individual commits. Most speedup comes from reducing the number of blocks required to activate DIP3 and from copying the datadir of the first node to all other masternodes, which reduces initial sync time.

This PR currently also includes #2641 which I'll remove after merge.

@UdjinM6 UdjinM6 added this to the 14.0 milestone Jan 23, 2019
@codablock codablock force-pushed the pr_dip3_fastertests branch from 9c3f264 to 059fba8 Compare January 23, 2019 14:04
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (let's see if travis thinks so too :)) but I wonder if we could just tweak regtest params globally (in chainparams.cpp) and reuse cache (setup_clean_chain == False) instead of reimplementing data copy etc.

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@UdjinM6
Copy link

UdjinM6 commented Jan 23, 2019

Some stats from my local machine.

Before:

TEST                     | PASSED | DURATION

autoix-mempool.py        | True   | 557 s
dip3-deterministicmns.py | False  | 325 s
llmq-signing.py          | True   | 357 s
p2p-autoinstantsend.py   | False  | 426 s
p2p-instantsend.py       | False  | 468 s

ALL                      | False  | 2133 s (accumulated)

Runtime: 682 s

(False == block sync simply failed at some point)

After:

TEST                     | PASSED | DURATION

autoix-mempool.py        | True   | 155 s
dip3-deterministicmns.py | True   | 460 s
llmq-signing.py          | True   | 99 s
p2p-autoinstantsend.py   | True   | 179 s
p2p-instantsend.py       | True   | 128 s

ALL                      | True   | 1021 s (accumulated)

Runtime: 460 s

👍

@UdjinM6 UdjinM6 merged commit 7ee31cb into dashpay:develop Jan 23, 2019
@codablock codablock deleted the pr_dip3_fastertests branch January 23, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants