Fix off-by-1 in phase calculations and the rest of llmq-signing.py issues #2641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
previously approved these changes
Jan 23, 2019
codablock
left a comment
codablock
left a comment
There was a problem hiding this comment.
was about to fix this as well ;)
utACK
Author
|
Still failing, not sure why... |
UdjinM6
force-pushed
the
fixoffbyoneinphases
branch
from
7b28cad to
0c60b99
Compare
UdjinM6
force-pushed
the
fixoffbyoneinphases
branch
from
0c60b99 to
ee883cf
Compare
UdjinM6
changed the title
Author
|
Tests still fail but this time it's dip3 one. And it didn't fail in my repo https://travis-ci.org/UdjinM6/dash/builds/483384518... |
|
dip3 test failures were bad luck...the last 2 DKG rounds selected the 10 healthy nodes and thus did not result in punishment. My plan is to implement the DKG debug status stuff for the dip3 tests as well so that the DKG can run faster and thus more often, increasing the likelihood of punishment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.