Backport missing PRs from Bitcoin 0.14 - Part 4 #1849

codablock · 2018-01-12T09:47:23Z

Continuation of #1770

94a34a5 Fix relaypriority calculation error (maiiz)

…)SIG e41bd44 Add policy: null signature for failed CHECK(MULTI)SIG (Johnson Lau)

…w 0 fee fa4bfb4 [wallet, policy] ParameterInteraction: Don't allow 0 fee (MarcoFalke)

…en service ac01ff2 doc: Add privacy recommendation when running hidden service (Wladimir J. van der Laan)

5776e8a [depends] Fix Qt compilation with Xcode 8 (fanquake)

0c4e6ce Add MIT license to build-aux/m4 scripts (Luke Dashjr) 3f8a5d8 Trivial: build-aux/m4/l_atomic: Fix typo (Luke Dashjr) 3b4b6dc Add MIT license to autogen.sh and share/genbuild.sh (Luke Dashjr) f4dffdd Add MIT license to Makefiles (Luke Dashjr)

… read fa05cfd [rpc] throw JSONRPCError when utxo set can not be read (MarcoFalke)

…t timeouts a0f8482 [qa] Split up slow RPC calls to avoid pruning test timeouts (Suhas Daftuar)

64d9507 [WIP] Remove unused statement in serialization (Pavel Janík)

fa9cd25 [qa] blockstore: Switch to dumb dbm (MarcoFalke)

7e5fd71 Do not include env_win.cc on non-Windows systems (Pavel Janík)

…g text files 30930e8 test: Explicitly set encoding to utf8 when opening text files (Wladimir J. van der Laan)

1d28faf test: Avoid ConnectionResetErrors during RPC tests (Wladimir J. van der Laan)

54e5d7c Add bitcoin-tx JSON tests (jnewbery)

…le is empty da94697 bitcoin-util-test.py should fail if the output file is empty (jnewbery)

…ually b82f493 Add option to run bitcoin-util-test.py manually (jnewbery)

a92bf4a bitcoind: Daemonize using daemon(3) (Matthew King)

203e2dd Mention Gitian building script in doc. (Lauda)

fa66609 [qa] mininode: Only allow named args in wait_until (MarcoFalke)

2ca7faa Squashed 'src/univalue/' changes from daf1285..16a1f7f (MarcoFalke)

fa7c35c [qa] util: Move wait_bitcoinds() into stop_nodes() (MarcoFalke)

…e from global mapArgs 3450c18 Globals: Decouple GetConfigFile and ReadConfigFile from global mapArgs (Jorge Timón)

…ation comment f00705a serialize: Deprecate `begin_ptr` / `end_ptr` (Wladimir J. van der Laan) 47314e6 prevector: add C++11-like data() method (Wladimir J. van der Laan)

…quested disconnect 905bc68 net: fix a few cases where messages were sent rather than dropped upon disconnection (Cory Fields)

eeeebdd [doc] Rework docs (MarcoFalke)

…neheight is the lowest, not highest, block a78e542 Bugfix: Trivial: RPC: getblockchaininfo help: pruneheight is the lowest, not highest, block (Luke Dashjr)

7d8afb4 [Doc] Improve GitHub issue template (fanquake)

…ld instructions. 2920be2 Update INSTALL landing redirection notice for build instructions. (randy-waterhouse)

621441a add verbose mode to bitcoin-util-test.py (jnewbery)

3f92bc9 doc: Add build instructions for FreeBSD (Wladimir J. van der Laan)

…Header 1df3111 protocol.h: Make enums in GetDataMsg concrete values (Wladimir J. van der Laan) 2c09a52 protocol.h: Move MESSAGE_START_SIZE into CMessageHeader (Wladimir J. van der Laan) f9bd92d version.h: s/shord/short/ in comment (Wladimir J. van der Laan)

6dd3723 Set minimum required Boost to 1.47.0 (fanquake) 282abd8 [build-aux] Boost_Base serial 27 (fanquake)

b0aea80 Sync bitcoin-tx with tx version policy (BtcDrak)

…eDeprecatedFieldRPC b26a7b5 RPC: Chainparams: Remove Chainparams::fTestnetToBeDeprecatedFieldRPC (Jorge Timón)

7c1716f Documentation for Building on Windows with WSL (poole_party)

5eaaa83 Kill insecure_random and associated global state (Wladimir J. van der Laan)

aa9d3c9 add software-properties-common (Steven)

… builds 83c0f7f trivial: update 0.13.0 release note info on linux arm builds (mruddy)

fab5ca8 contrib: Add README for pgp keys (MarcoFalke)

fa8b02d [rpc] rawtx: Prepare fLimitFree to make it an option (MarcoFalke) fa28bfa [wallet] Set fLimitFree = true (MarcoFalke)

9fce062 [c++11] Use std::unique_ptr for block creation. (Daniel Kraft)

164196b Simple Update to File 'bitcoin-qt.desktop' (matthias)

5805ac8 Add preciousblock tests (Pieter Wuille) 5127c4f Add preciousblock RPC (Pieter Wuille)

18dacf9 Add microbenchmarks to profile more code paths. (Russell Yanofsky)

...due to out-of-order backporting of per-UTXO.

b55d823 Explicitly state that PPA is for Ubuntu only (anduck)

a1919ad Report NodeId in misbehaving debug (R E Broadley)

gladcow · 2018-01-12T13:45:42Z

src/dashd.cpp

-            if (sid < 0)
-                fprintf(stderr, "Error: setsid() returned %d errno %d\n", sid, errno);
+#else
+            fprintf(stderr, "Error: -daemon is not supported on this operating system\n");


Now I'm getting this error on Ubuntu 17. I'm trying to understand details now, but it looks like a problem

Make sure to make clean && ./autogen.sh

Yes, I'm sorry, it's my error, I've missed autogen.sh.

UdjinM6

👍

As for changes: doc/release-process.md misses
+* Update [`BLOCK_CHAIN_SIZE`](/src/qt/intro.cpp) to the current size plus some overhead.
from 8879 + see inline comments

UdjinM6 · 2018-01-12T13:04:16Z

Makefile.am

@@ -1,3 +1,7 @@
+# Copyright (c) 2013-2016 The Bitcoin Core developers
+# Distributed under the MIT software license, see the accompanying


Most Makefiles (besides probably src/Makefile.leveldb.include) are modified by us already, so we should probably add a // Copyright (c) 2014-2017 The Dash Core developers line as well (note: this comment applies to files modified in a26bad0).

UdjinM6 · 2018-01-12T13:21:36Z

INSTALL.md

@@ -0,0 +1,5 @@
+Building Bitcoin


s/Bitcoin/Dash Core/

UdjinM6 · 2018-01-12T13:21:51Z

INSTALL.md

+================
+
+See doc/build-*.md for instructions on building the various
+elements of the Bitcoin Core reference implementation of Bitcoin.


s/Bitcoin/Dash/

UdjinM6 · 2018-01-12T13:23:29Z

doc/build-unix.md

+This will give a warning "configure: WARNING: Found Berkeley DB other
+than 4.8; wallets opened by this build will not be portable!", but as FreeBSD never
+had a binary release, this may not matter. If backwards compatibility
+with 4.8-built Bitcoin Core is needed follow the steps under "Berkeley DB" above.


s/Bitcoin/Dash/

UdjinM6 · 2018-01-12T13:38:17Z

src/random.h

+ * This class is not thread-safe.
 */
-void seed_insecure_rand(bool fDeterministic = false);
+class FastRandomContext {


FastRandomContext is basically a clone of InsecureRand which was implemented in Dash earlier. I think it makes sense to s/InsecureRand/FastRandomContext/ elsewhere in code and drop InsecureRand in random.h/cpp now.

UdjinM6 · 2018-01-12T13:57:01Z

src/test/data/bitcoin-util-test.json

@@ -1,37 +1,73 @@
 [
  { "exec": "././dash-tx",


s/"././dash-tx"/"./dash-tx"/

codablock · 2018-01-12T15:03:57Z

@UdjinM6 Regarding the missing change in doc/release-process.md, I've omitted quite a lot in release-process.md as it has diverged much from Bitcoin (partly due to custom changes, partly due to out of order backporting). I have an item on my TODO to go through the release-process.md when I reach Bitcoin 0.15 to compare and finally add all missing stuff. Same with some other documentation.

Working on the other stuff now.

Also extend FastRandomContext to be compatible to existing uses, especially with std::random_shuffle

codablock · 2018-01-12T15:39:33Z

Fixed review comments

UdjinM6

slightly tested ACK

laanwj and others added 30 commits January 12, 2018 08:02

Merge bitcoin#8357: [mempool] Fix relaypriority calculation error

b224c02

94a34a5 Fix relaypriority calculation error (maiiz)

Merge bitcoin#8634: Add policy: null signature for failed CHECK(MULTI…

a75d611

…)SIG e41bd44 Add policy: null signature for failed CHECK(MULTI)SIG (Johnson Lau)

Merge bitcoin#8814: [wallet, policy] ParameterInteraction: Don't allo…

8b8362f

…w 0 fee fa4bfb4 [wallet, policy] ParameterInteraction: Don't allow 0 fee (MarcoFalke)

Merge bitcoin#8823: doc: Add privacy recommendation when running hidd…

f9431a1

…en service ac01ff2 doc: Add privacy recommendation when running hidden service (Wladimir J. van der Laan)

Merge bitcoin#8820: [depends] Fix Qt compilation with Xcode 8

3a503b9

5776e8a [depends] Fix Qt compilation with Xcode 8 (fanquake)

Merge bitcoin#8832: [rpc] throw JSONRPCError when utxo set can not be…

79f6d3d

… read fa05cfd [rpc] throw JSONRPCError when utxo set can not be read (MarcoFalke)

Merge bitcoin#8827: [qa] Split up slow RPC calls to avoid pruning tes…

cf4bdab

…t timeouts a0f8482 [qa] Split up slow RPC calls to avoid pruning test timeouts (Suhas Daftuar)

Merge bitcoin#8658: Remove unused statements in serialization

575f625

64d9507 [WIP] Remove unused statement in serialization (Pavel Janík)

Merge bitcoin#8834: [qa] blockstore: Switch to dumb dbm

e6af218

fa9cd25 [qa] blockstore: Switch to dumb dbm (MarcoFalke)

Merge bitcoin#8826: Do not include env_win.cc on non-Windows systems

272fddc

7e5fd71 Do not include env_win.cc on non-Windows systems (Pavel Janík)

Merge bitcoin#8840: test: Explicitly set encoding to utf8 when openin…

942fe0e

…g text files 30930e8 test: Explicitly set encoding to utf8 when opening text files (Wladimir J. van der Laan)

Merge bitcoin#8839: test: Avoid ConnectionResetErrors during RPC tests

6b1842a

1d28faf test: Avoid ConnectionResetErrors during RPC tests (Wladimir J. van der Laan)

Merge bitcoin#8829: Add bitcoin-tx JSON tests

963f6a6

54e5d7c Add bitcoin-tx JSON tests (jnewbery)

Merge bitcoin#8836: bitcoin-util-test.py should fail if the output fi…

972a44b

…le is empty da94697 bitcoin-util-test.py should fail if the output file is empty (jnewbery)

Merge bitcoin#8830: [test] Add option to run bitcoin-util-test.py man…

2f3abc6

…ually b82f493 Add option to run bitcoin-util-test.py manually (jnewbery)

Merge bitcoin#8813: bitcoind: Daemonize using daemon(3)

210242e

a92bf4a bitcoind: Daemonize using daemon(3) (Matthew King)

Merge bitcoin#8852: Mention Gitian building script in doc (Laudaa)

ba02e9d

203e2dd Mention Gitian building script in doc. (Lauda)

Merge bitcoin#8857: [qa] mininode: Only allow named args in wait_until

16532f8

fa66609 [qa] mininode: Only allow named args in wait_until (MarcoFalke)

Merge bitcoin#8863: univalue: Pull subtree

10127ae

2ca7faa Squashed 'src/univalue/' changes from daf1285..16a1f7f (MarcoFalke)

Merge bitcoin#8860: [qa] util: Move wait_bitcoinds() into stop_nodes()

23ac000

fa7c35c [qa] util: Move wait_bitcoinds() into stop_nodes() (MarcoFalke)

Merge bitcoin#8856: Globals: Decouple GetConfigFile and ReadConfigFil…

14483e4

…e from global mapArgs 3450c18 Globals: Decouple GetConfigFile and ReadConfigFile from global mapArgs (Jorge Timón)

Merge bitcoin#8850: Implement (begin|end)_ptr in C++11 and add deprec…

6e4dad9

…ation comment f00705a serialize: Deprecate `begin_ptr` / `end_ptr` (Wladimir J. van der Laan) 47314e6 prevector: add C++11-like data() method (Wladimir J. van der Laan)

Merge bitcoin#8862: Fix a few cases where messages were sent after re…

f45adb5

…quested disconnect 905bc68 net: fix a few cases where messages were sent rather than dropped upon disconnection (Cory Fields)

Merge bitcoin#8879: [doc] Rework docs

fb8d46d

eeeebdd [doc] Rework docs (MarcoFalke)

Merge bitcoin#8884: Bugfix: Trivial: RPC: getblockchaininfo help: pru…

1c1554f

…neheight is the lowest, not highest, block a78e542 Bugfix: Trivial: RPC: getblockchaininfo help: pruneheight is the lowest, not highest, block (Luke Dashjr)

Merge bitcoin#8887: [Doc] Improve GitHub issue template

d31c2d6

7d8afb4 [Doc] Improve GitHub issue template (fanquake)

Merge bitcoin#8896: Update INSTALL landing redirection notice for bui…

43a377a

…ld instructions. 2920be2 Update INSTALL landing redirection notice for build instructions. (randy-waterhouse)

Merge bitcoin#8881: Add some verbose logging to bitcoin-util-test.py

76641e6

621441a add verbose mode to bitcoin-util-test.py (jnewbery)

Merge bitcoin#8892: doc: Add build instructions for FreeBSD

75668f3

3f92bc9 doc: Add build instructions for FreeBSD (Wladimir J. van der Laan)

laanwj and others added 17 commits January 12, 2018 09:58

Merge bitcoin#8920: Set minimum required Boost to 1.47.0

19316b7

6dd3723 Set minimum required Boost to 1.47.0 (fanquake) 282abd8 [build-aux] Boost_Base serial 27 (fanquake)

Merge bitcoin#8932: Allow bitcoin-tx to create v2 transactions

ffc9673

b0aea80 Sync bitcoin-tx with tx version policy (BtcDrak)

Merge bitcoin#8921: RPC: Chainparams: Remove Chainparams::fTestnetToB…

c4faa32

…eDeprecatedFieldRPC b26a7b5 RPC: Chainparams: Remove Chainparams::fTestnetToBeDeprecatedFieldRPC (Jorge Timón)

Merge bitcoin#8935: Documentation: Building on Windows with WSL

5fc2e19

7c1716f Documentation for Building on Windows with WSL (poole_party)

Merge bitcoin#8914: Kill insecure_random and associated global state

239ce53

5eaaa83 Kill insecure_random and associated global state (Wladimir J. van der Laan)

Merge bitcoin#8929: add software-properties-common

3edeea3

aa9d3c9 add software-properties-common (Steven)

Merge bitcoin#8955: doc: update 0.13.0 release note info on linux arm…

0fd7c4e

… builds 83c0f7f trivial: update 0.13.0 release note info on linux arm builds (mruddy)

Merge bitcoin#8954: contrib: Add README for pgp keys

4fc77cc

fab5ca8 contrib: Add README for pgp keys (MarcoFalke)

Merge bitcoin#8287: [wallet] Set fLimitFree = true

0dcca9b

fa8b02d [rpc] rawtx: Prepare fLimitFree to make it an option (MarcoFalke) fa28bfa [wallet] Set fLimitFree = true (MarcoFalke)

Merge bitcoin#8223: [c++11] Use std::unique_ptr for block creation.

85706a0

9fce062 [c++11] Use std::unique_ptr for block creation. (Daniel Kraft)

Merge bitcoin#8908: Update bitcoin-qt.desktop

b02e461

164196b Simple Update to File 'bitcoin-qt.desktop' (matthias)

Merge bitcoin#6996: Add preciousblock RPC

6e871c0

5805ac8 Add preciousblock tests (Pieter Wuille) 5127c4f Add preciousblock RPC (Pieter Wuille)

Merge bitcoin#8873: Add microbenchmarks to profile more code paths.

2f86773

18dacf9 Add microbenchmarks to profile more code paths. (Russell Yanofsky)

Backport changes to ccoins_caching.cpp which were skipped

c858429

...due to out-of-order backporting of per-UTXO.

Merge bitcoin#8965: Mention that PPA doesn't support Debian

b84ea46

b55d823 Explicitly state that PPA is for Ubuntu only (anduck)

Merge bitcoin#8936: Report NodeId in misbehaving debug

89e959d

a1919ad Report NodeId in misbehaving debug (R E Broadley)

gladcow reviewed Jan 12, 2018

View reviewed changes

UdjinM6 requested changes Jan 12, 2018

View reviewed changes

codablock added 4 commits January 12, 2018 16:12

Dashify INSTALL.md and build-unix.md

7604a3a

Add Dash Copyright to Makefiles modified by Dash developers

5b8946c

Get rid of InsecureRand and use equivalent FastRandomContext

6989f94

Also extend FastRandomContext to be compatible to existing uses, especially with std::random_shuffle

Remove doubled "./" from bitcoin-util-test.json

8f13e25

UdjinM6 approved these changes Jan 12, 2018

View reviewed changes

UdjinM6 added this to the 12.3 milestone Jan 12, 2018

UdjinM6 merged commit c2e0075 into dashpay:develop Jan 12, 2018

codablock deleted the pr_backport_bitcoin_0.14-4 branch January 13, 2018 11:19

PastaPastaPasta mentioned this pull request Jul 18, 2019

Backports 0.15 pr21 #3029

Merged

		@@ -1,3 +1,7 @@
		# Copyright (c) 2013-2016 The Bitcoin Core developers
		# Distributed under the MIT software license, see the accompanying

Backport missing PRs from Bitcoin 0.14 - Part 4 #1849

Backport missing PRs from Bitcoin 0.14 - Part 4 #1849

Uh oh!

Conversation

codablock commented Jan 12, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codablock commented Jan 12, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codablock commented Jan 12, 2018

Uh oh!

UdjinM6 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codablock commented Jan 12, 2018 •

edited

Loading