-
Notifications
You must be signed in to change notification settings - Fork 36.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Copyright headers for build scripts #8784
Conversation
I sign-off on changing the license of these build scripts as indicated. |
I approve. |
I approve of adding license information. I don't think it's a great idea to include the typo fixing commit here given the subject of this PR, but you probably don't care what I think about that. |
I approve of placing the build scripts under MIT license. |
Can't we have a general policy that everything committed to the repository must be put under MIT license? (e.g. github shows this repository as MIT) no matter what is at the top of the individual file. This just keeps going on and on and on (this pull, #8702, #8701, #8700, #8676, are just the last few days), Micromanaging every file in this way results in a lot of overhead for everyone involved, which could be spent on solving one of the many actual problems. So I really never want to repeat this again. |
I approve. |
👍 from me. @laanwj Agreed; I already assumed from the top-level COPYING file containing the MIT license that any contributions were under the MIT license unless otherwise specified. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
I approve |
I approve.
|
Approved On Thu, Sep 22, 2016, 11:47 Pieter Wuille notifications@github.com wrote:
|
Approved |
1 similar comment
Approved |
I approve. |
Approved |
Approved. |
I approve and agree with @laanwj. |
@luke-jr Many of those that were pinged already gave a permanent ACK on all of their past contributions to this repo to be explicitly MIT licensed. |
@MarcoFalke Is there a record of who has done so? |
Approved. |
@luke-jr e.g. #7300 (comment) |
Yes, my point is there's no easy way to find these. |
Fine with me. |
Approved. But also like someone said:
|
Github-Pull: bitcoin#8784 Rebased-From: 3b4b6dc
Github-Pull: bitcoin#8784 Rebased-From: 3f8a5d8
Github-Pull: bitcoin#8784 Rebased-From: 0c4e6ce
Github-Pull: bitcoin#8784 Rebased-From: f4dffdd
Github-Pull: bitcoin#8784 Rebased-From: 3b4b6dc
Github-Pull: bitcoin#8784 Rebased-From: 3f8a5d8
Github-Pull: bitcoin#8784 Rebased-From: 0c4e6ce
Github-Pull: bitcoin#8784 Rebased-From: 0c4e6ce
Github-Pull: bitcoin#8784 Rebased-From: f4dffdd
Github-Pull: bitcoin#8784 Rebased-From: 3b4b6dc
Github-Pull: bitcoin#8784 Rebased-From: 3f8a5d8
Github-Pull: bitcoin#8784 Rebased-From: 3b4b6dc
Update license info Includes commits cherry-picked from bitcoin/bitcoin#8784 with some minor changes. Fixes #2827.
Update LevelDB to upstream commit f545dfabf Cherry-picked from the following upstream PRs: - bitcoin/bitcoin#7911 - bitcoin/bitcoin#7982 - bitcoin/bitcoin#8133 - bitcoin/bitcoin#8784 - Only the missing changes. - bitcoin/bitcoin#8826 - bitcoin/bitcoin#8613 - bitcoin/bitcoin#10544 - bitcoin/bitcoin#10633 - Only the changes to files and code we have. - bitcoin/bitcoin#10806 - bitcoin/bitcoin#10958 - bitcoin/bitcoin#12451 - bitcoin/bitcoin#13925 - bitcoin/bitcoin#15270 This upgrades LevelDB in the exact same commit progression as upstream, up to January 2019.
This needs sign-off from:
@morcos @anddam@brandondahler@btcdrak @casey@theuni @cozz@dcousens @ers35 @EthanHeilman @gavinandresen@gmaxwell@jamesob@jgarzik @jonasschnelli@jtimon@joshtriplett@kazcw@maraoz@MarcoFalke@maaku@TheBlueMatt @fanquake@musalbas@pstratem@paveljanik@Diapolo@sipa @rnicoll @SergioDemianLerner @sdaftuar @laanwj @yurizhykin @dexX7 @nomnombtc @ntrgn @ptschip @randy-waterhouse @sinetek@knocte@joshtriplett@ajtowns @dooglus @onlyjob @wtogami@imwuzhhPermission from Tim Kosse has already been obtained: