Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copyright headers for build scripts #8784

Merged
merged 4 commits into from
Sep 29, 2016
Merged

Conversation

luke-jr
Copy link
Member

@luke-jr luke-jr commented Sep 21, 2016

@ers35
Copy link
Contributor

ers35 commented Sep 21, 2016

I sign-off on changing the license of these build scripts as indicated.

@maaku
Copy link
Contributor

maaku commented Sep 21, 2016

I approve.

@dooglus
Copy link
Contributor

dooglus commented Sep 22, 2016

I approve of adding license information.

I don't think it's a great idea to include the typo fixing commit here given the subject of this PR, but you probably don't care what I think about that.

@randy-waterhouse
Copy link
Contributor

I approve of placing the build scripts under MIT license.

@laanwj
Copy link
Member

laanwj commented Sep 22, 2016

Can't we have a general policy that everything committed to the repository must be put under MIT license? (e.g. github shows this repository as MIT) no matter what is at the top of the individual file.

This just keeps going on and on and on (this pull, #8702, #8701, #8700, #8676, are just the last few days), Micromanaging every file in this way results in a lot of overhead for everyone involved, which could be spent on solving one of the many actual problems.

So I really never want to repeat this again.

@laanwj laanwj added the Docs label Sep 22, 2016
@EthanHeilman
Copy link
Contributor

I approve.

@joshtriplett
Copy link
Contributor

👍 from me.

@laanwj Agreed; I already assumed from the top-level COPYING file containing the MIT license that any contributions were under the MIT license unless otherwise specified.

Copy link
Contributor

@dcousens dcousens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@knocte
Copy link
Contributor

knocte commented Sep 22, 2016

I approve

@sipa
Copy link
Member

sipa commented Sep 22, 2016 via email

@maraoz
Copy link
Contributor

maraoz commented Sep 22, 2016

Approved

On Thu, Sep 22, 2016, 11:47 Pieter Wuille notifications@github.com wrote:

I approve.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8784 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AARh1Qj6TjszqTSAkIMxKu7mj_YpFDJ-ks5qsfpigaJpZM4KDX7b
.

@ajtowns
Copy link
Contributor

ajtowns commented Sep 22, 2016

Approved

1 similar comment
@paveljanik
Copy link
Contributor

Approved

@jonasschnelli
Copy link
Contributor

I approve.

@rnicoll
Copy link
Contributor

rnicoll commented Sep 22, 2016

Approved

@onlyjob
Copy link
Contributor

onlyjob commented Sep 22, 2016

Approved.

@rodentrabies
Copy link
Contributor

I approve and agree with @laanwj.

@maflcko
Copy link
Member

maflcko commented Sep 22, 2016

@luke-jr Many of those that were pinged already gave a permanent ACK on all of their past contributions to this repo to be explicitly MIT licensed.

@luke-jr
Copy link
Member Author

luke-jr commented Sep 22, 2016

@MarcoFalke Is there a record of who has done so?

@dexX7
Copy link
Contributor

dexX7 commented Sep 22, 2016

Approved.

@maflcko
Copy link
Member

maflcko commented Sep 22, 2016

@luke-jr e.g. #7300 (comment)

@luke-jr
Copy link
Member Author

luke-jr commented Sep 22, 2016

Yes, my point is there's no easy way to find these.

@musalbas
Copy link
Contributor

Fine with me.

@nomnombtc
Copy link
Contributor

Approved.

But also like someone said:

I already assumed from the top-level COPYING file containing the MIT license that any contributions were under the MIT license unless otherwise specified.

luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016
luke-jr added a commit to bitcoinknots/bitcoin that referenced this pull request Oct 20, 2016
laanwj pushed a commit to laanwj/bitcoin that referenced this pull request Oct 27, 2016
laanwj pushed a commit to laanwj/bitcoin that referenced this pull request Oct 27, 2016
laanwj pushed a commit to laanwj/bitcoin that referenced this pull request Oct 27, 2016
laanwj pushed a commit to laanwj/bitcoin that referenced this pull request Oct 27, 2016
schinzelh pushed a commit to dashpay/dash that referenced this pull request Oct 23, 2017
schinzelh pushed a commit to dashpay/dash that referenced this pull request Oct 23, 2017
schinzelh pushed a commit to dashpay/dash that referenced this pull request Oct 23, 2017
schinzelh pushed a commit to dashpay/dash that referenced this pull request Oct 23, 2017
codablock pushed a commit to codablock/dash that referenced this pull request Jan 12, 2018
0c4e6ce Add MIT license to build-aux/m4 scripts (Luke Dashjr)
3f8a5d8 Trivial: build-aux/m4/l_atomic: Fix typo (Luke Dashjr)
3b4b6dc Add MIT license to autogen.sh and share/genbuild.sh (Luke Dashjr)
f4dffdd Add MIT license to Makefiles (Luke Dashjr)
sickpig referenced this pull request in sickpig/BitcoinUnlimited Apr 27, 2018
0c4e6ce Add MIT license to build-aux/m4 scripts (Luke Dashjr)
3f8a5d8 Trivial: build-aux/m4/l_atomic: Fix typo (Luke Dashjr)
3b4b6dc Add MIT license to autogen.sh and share/genbuild.sh (Luke Dashjr)
f4dffdd Add MIT license to Makefiles (Luke Dashjr)
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Nov 9, 2018
andvgal pushed a commit to energicryptocurrency/gen2-energi that referenced this pull request Jan 6, 2019
0c4e6ce Add MIT license to build-aux/m4 scripts (Luke Dashjr)
3f8a5d8 Trivial: build-aux/m4/l_atomic: Fix typo (Luke Dashjr)
3b4b6dc Add MIT license to autogen.sh and share/genbuild.sh (Luke Dashjr)
f4dffdd Add MIT license to Makefiles (Luke Dashjr)
zkbot added a commit to zcash/zcash that referenced this pull request Jul 24, 2019
Update license info

Includes commits cherry-picked from bitcoin/bitcoin#8784 with some minor changes.

Fixes #2827.
zkbot added a commit to zcash/zcash that referenced this pull request Sep 25, 2020
Update LevelDB to upstream commit f545dfabf

Cherry-picked from the following upstream PRs:

- bitcoin/bitcoin#7911
- bitcoin/bitcoin#7982
- bitcoin/bitcoin#8133
- bitcoin/bitcoin#8784
  - Only the missing changes.
- bitcoin/bitcoin#8826
- bitcoin/bitcoin#8613
- bitcoin/bitcoin#10544
- bitcoin/bitcoin#10633
  - Only the changes to files and code we have.
- bitcoin/bitcoin#10806
- bitcoin/bitcoin#10958
- bitcoin/bitcoin#12451
- bitcoin/bitcoin#13925
- bitcoin/bitcoin#15270

This upgrades LevelDB in the exact same commit progression as upstream, up to January 2019.
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.