Drop IsInputAssociatedWithPubkey and optimize CheckOutpoint #1783
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codablock
reviewed
Dec 20, 2017
src/masternode.cpp
Outdated
| // Verify that sig time is legit, should be at least not earlier than the timestamp of the block | ||
| // at which collateral became nMasternodeMinimumConfirmations blocks deep. | ||
| // NOTE: this is not accurate because block timestamp is NOT guaranteed to be 100% correct one. | ||
| CBlockIndex* pRequredConfIndex = chainActive[nHeight + Params().GetConsensus().nMasternodeMinimumConfirmations - 1]; // block where tx got nMasternodeMinimumConfirmations |
|
utACK (only small type found) |
|
utACK |
andvgal
added a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing two (heavy)
GetTransactioncalls by relying onGetUTXOCoinand height passed back fromCheckCollateral. This way we should no longer be doing the same work twice here, and switching from full tx set to utxo only should also help to speed things up. DroppingIsInputAssociatedWithPubkeysince it's no longer used anywhere after applying changes described above.