Refactor and optimize IsInputAssociatedWithPubkey #1781
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the extra GetTransaction call by passing height back from IsInputAssociatedWithPubkey function and using it in CheckOutpoint. Also remove GetTransaction call in IsInputAssociatedWithPubkey in favor of GetUTXOCoins which is more efficient and does the same thing. The only difference is that GetUTXOCoins will fail if the collateral has moved whereas GetTransaction will not. I hope that is a safe assumption as if collateral is moved I would like to think that this function should fail anyway (seems to be only called when a masternode broadcast has occured)
Author
|
Just another step to remove as many GetTransaction calls as possible (I know we still cannot remove the txindex dependency entirely but we are getting there 👍 ) |
|
I like the idea, I would however go even further #1783 |
Author
|
Agreed. Good thinking. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the extra GetTransaction call by passing height back from IsInputAssociatedWithPubkey function and using it in CheckOutpoint. Also remove GetTransaction call in IsInputAssociatedWithPubkey in favor of GetUTXOCoins which is more efficient and does the same thing. The only difference is that GetUTXOCoins will fail if the collateral has moved whereas GetTransaction will not. I hope that is a safe assumption as if collateral is moved I would like to think that this function should fail anyway (seems to be only called when a masternode broadcast has occured)