Skip to content

Commit

Permalink
rpc2: Finalized event doesn't indicate that the best block changes (p…
Browse files Browse the repository at this point in the history
…aritytech#4872)

We should not print a warning if the best block stays the same between
two finality events. There is no requirement that this changes. For sure
this doesn't need to be an error message.
  • Loading branch information
bkchr authored Jun 25, 2024
1 parent 63e2644 commit a0fc3b5
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ use futures::{
};
use futures_util::future::Either;
use jsonrpsee::SubscriptionSink;
use log::{debug, error};
use log::debug;
use sc_client_api::{
Backend, BlockBackend, BlockImportNotification, BlockchainEvents, FinalityNotification,
};
Expand Down Expand Up @@ -572,7 +572,7 @@ where
// The information from `.info()` is updated from the DB as the last
// step of the finalization and it should be up to date.
// If the info is outdated, there is nothing the RPC can do for now.
error!(
debug!(
target: LOG_TARGET,
"[follow][id={:?}] Client does not contain different best block",
self.sub_id,
Expand Down

0 comments on commit a0fc3b5

Please sign in to comment.