rpc2: Finalized event doesn't indicate that the best block changes #4872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not print a warning if the best block stays the same between two finality events. There is no requirement that this changes. For sure this doesn't need to be an error message.
|
The CI pipeline was cancelled due to failure one of the required jobs. |
dmitry-markin
approved these changes
Jun 25, 2024
skunert
approved these changes
Jun 25, 2024
lexnv
approved these changes
Jun 25, 2024
TarekkMA
pushed a commit
to moonbeam-foundation/polkadot-sdk
that referenced
this pull request
Aug 2, 2024
…aritytech#4872) We should not print a warning if the best block stays the same between two finality events. There is no requirement that this changes. For sure this doesn't need to be an error message.
sfffaaa
pushed a commit
to peaqnetwork/polkadot-sdk
that referenced
this pull request
Dec 27, 2024
…aritytech#4872) We should not print a warning if the best block stays the same between two finality events. There is no requirement that this changes. For sure this doesn't need to be an error message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not print a warning if the best block stays the same between two finality events. There is no requirement that this changes. For sure this doesn't need to be an error message.