Skip to content

Conversation

@jslee02
Copy link
Member

@jslee02 jslee02 commented Nov 2, 2025

Fixes #1683, #1818

Summary

  • cherry-picked Haidar's servo-limit commits onto to preserve authorship
  • added regression plus SDF fixture to reproduce the stuck-at-limit bug
  • retained existing Issue1583 regression coverage while validating the fix

Testing

  • cmake --build build/default/cpp/Release --target test_Issue1583
  • ./tests/regression/test_Issue1583

@jslee02 jslee02 mentioned this pull request Nov 2, 2025
7 tasks
@codecov
Copy link

codecov bot commented Nov 2, 2025

Codecov Report

❌ Patch coverage is 95.45455% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.68%. Comparing base (f6742e0) to head (7c0e67d).
⚠️ Report is 1 commits behind head on release-6.16.

Files with missing lines Patch % Lines
dart/constraint/JointConstraint.cpp 95.45% 2 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-6.16    #2086      +/-   ##
================================================
+ Coverage         58.64%   58.68%   +0.03%     
================================================
  Files               384      384              
  Lines             32036    32056      +20     
  Branches           3866     3870       +4     
================================================
+ Hits              18789    18812      +23     
+ Misses            13247    13244       -3     
Flag Coverage Δ
unittests 58.68% <95.45%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
dart/constraint/JointConstraint.cpp 75.96% <95.45%> (+2.25%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jslee02 jslee02 changed the title Allow servo joints to recover from position limits [6.16] Allow servo joints to recover from position limits Nov 2, 2025
@jslee02
Copy link
Member Author

jslee02 commented Nov 3, 2025

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. You're on a roll.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jslee02 jslee02 added this to the DART 6.16.0 milestone Nov 4, 2025
@jslee02 jslee02 enabled auto-merge (squash) November 4, 2025 16:19
@jslee02 jslee02 merged commit 2dff6f0 into release-6.16 Nov 4, 2025
30 of 31 checks passed
@jslee02 jslee02 deleted the servo-limit-6.16 branch November 4, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants