Skip to content

Add initial support for build_runner serve #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 3 additions & 15 deletions webdev/lib/src/command/build_command.dart
Original file line number Diff line number Diff line change
@@ -1,29 +1,17 @@
import 'dart:async';

import 'package:io/io.dart';

import 'package:args/command_runner.dart';
import 'build_runner_command_base.dart';

/// Command to execute pub run build_runner build.
class BuildCommand extends Command {
class BuildCommand extends BuildRunnerCommandBase {
@override
final name = 'build';

@override
final description = 'Run builders to build a package.';

BuildCommand() {
// TODO(nshahan) Expose more args passed to build_runner build.
// build_runner might expose args for use in wrapping scripts like this one.
argParser
..addOption('output',
abbr: 'o', help: 'A directory to write the result of a build to.')
..addFlag('verbose',
abbr: 'v',
defaultsTo: false,
negatable: false,
help: 'Enables verbose logging.');
}

@override
Future run() async {
final manager = new ProcessManager();
Expand Down
18 changes: 18 additions & 0 deletions webdev/lib/src/command/build_runner_command_base.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import 'package:args/command_runner.dart';

/// Extend to get a command with the arguments common to all build_runner
/// commands.
abstract class BuildRunnerCommandBase extends Command {
BuildRunnerCommandBase() {
// TODO(nshahan) Expose more common args passed to build_runner commands.
// build_runner might expose args for use in wrapping scripts like this one.
argParser
..addOption('output',
abbr: 'o', help: 'A directory to write the result of a build to.')
..addFlag('verbose',
abbr: 'v',
defaultsTo: false,
negatable: false,
help: 'Enables verbose logging.');
}
}
35 changes: 35 additions & 0 deletions webdev/lib/src/command/serve_command.dart
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
import 'dart:async';

import 'package:io/io.dart';

import 'build_runner_command_base.dart';

/// Command to execute pub run build_runner serve.
class ServeCommand extends BuildRunnerCommandBase {
@override
final name = 'serve';

@override
final description = 'Run a local web development server and a file system'
' watcher that re-builds on changes.';

ServeCommand() {
// TODO(nshahan) Expose more args passed to build_runner serve.
// build_runner might expose args for use in wrapping scripts like this one.
argParser
..addOption('hostname',
defaultsTo: 'localhost', help: 'Specify the hostname to serve on.');
}

@override
Future run() async {
final manager = new ProcessManager();
final executable = 'pub';
final arguments = ['run', 'build_runner', 'serve', '--assume-tty'];
arguments.addAll(argResults.arguments);
var spawn = await manager.spawn(executable, arguments);

await spawn.exitCode;
await sharedStdIn.terminate();
}
}
13 changes: 5 additions & 8 deletions webdev/lib/src/webdev_command_runner.dart
Original file line number Diff line number Diff line change
@@ -1,13 +1,10 @@
import 'package:args/command_runner.dart';

import 'command/build_command.dart';
import 'command/serve_command.dart';

/// All available top level commands.
CommandRunner webdevCommandRunner() {
final commandRunner =
new CommandRunner('webdev', 'A tool to develop Dart web projects.');

commandRunner.addCommand(new BuildCommand());

return commandRunner;
}
CommandRunner webdevCommandRunner() =>
new CommandRunner('webdev', 'A tool to develop Dart web projects.')
..addCommand(new BuildCommand())
..addCommand(new ServeCommand());