Add initial support for build_runner serve #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor shared arguments into abstract class.
alorenzen
reviewed
Jan 12, 2018
|
|
||
| /// All available top level commands. | ||
| CommandRunner webdevCommandRunner() { | ||
| final commandRunner = | ||
| new CommandRunner('webdev', 'A tool to develop Dart web projects.'); | ||
|
|
||
| commandRunner.addCommand(new BuildCommand()); | ||
| commandRunner.addCommand(new ServeCommand()); |
There was a problem hiding this comment.
Super minor nit:
I prefer cascades here:
commandRunner
..addCommand(new BuildComand())
..addCommand(new ServeCommand());
I think this scales up better when we have 5 or 6 commands.
alorenzen
approved these changes
Jan 12, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor shared arguments into abstract class.