Skip to content

Correctly parse build options #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Correctly parse build options #331

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions webdev/lib/src/command/serve_command.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,12 +103,9 @@ refresh: Performs a full page refresh.
// Forward remaining arguments as Build Options to the Daemon.
// This isn't documented. Should it be advertised?
var buildOptions = buildRunnerArgs(pubspecLock, configuration)
..addAll(argResults.rest
.where((arg) => !arg.contains(':') || arg.startsWith('--'))
.toList());
var directoryArgs = argResults.rest
.where((arg) => arg.contains(':') || !arg.startsWith('--'))
.toList();
..addAll(argResults.rest.where((arg) => arg.startsWith('-')).toList());
var directoryArgs =
argResults.rest.where((arg) => !arg.startsWith('-')).toList();
var targetPorts = _parseDirectoryArgs(directoryArgs);
var workflow =
await DevWorkflow.start(configuration, buildOptions, targetPorts);
Expand Down