Skip to content

Correctly parse build options #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2019
Merged

Correctly parse build options #331

merged 1 commit into from
Apr 24, 2019

Conversation

grouma
Copy link
Member

@grouma grouma commented Apr 24, 2019 •
edited
Loading

Towards #329

@grouma grouma requested a review from jakemac53 April 24, 2019 20:43
natebosch
natebosch approved these changes Apr 24, 2019
View reviewed changes
Copy link
Member

@natebosch natebosch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth a regression test?

@grouma
Copy link
Member Author

grouma commented Apr 24, 2019

Yes. I don't want to block this PR on the test though so I won't close the tracking bug.

@grouma grouma merged commit 207dfd5 into master Apr 24, 2019
@grouma grouma deleted the build-options branch April 24, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natebosch natebosch natebosch approved these changes

@jakemac53 jakemac53 Awaiting requested review from jakemac53

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grouma @natebosch