Skip to content

Move chrome profile to .dart_tools #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 22, 2019
Merged

Move chrome profile to .dart_tools #316

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
50173dc
Move chrome profile to .dart_toosl
grouma Apr 22, 2019
2395bf4
format
grouma Apr 22, 2019
4d0513f
fix weird call
grouma Apr 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion webdev/lib/src/serve/chrome.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import 'dart:async';
import 'dart:convert';
import 'dart:io';

import 'package:path/path.dart' as p;
import 'package:webkit_inspection_protocol/webkit_inspection_protocol.dart';

import 'utils.dart';
Expand Down Expand Up @@ -62,7 +63,9 @@ class Chrome {
///
/// Each url in [urls] will be loaded in a separate tab.
static Future<Chrome> start(List<String> urls, {int port}) async {
var dataDir = Directory.systemTemp.createTempSync();
var dataDir = Directory(p.joinAll(
[Directory.current.path, '.dart_tool', 'webdev', 'chrome_profile']))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we already made some guarantee that cwd is the package root?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes: https://github.com/dart-lang/webdev/blob/master/webdev/lib/src/command/serve_command.dart#L102

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NICE!

..createSync(recursive: true);
port = port == null || port == 0 ? await findUnusedPort() : port;
var args = [
// Using a tmp directory ensures that a new instance of chrome launches
Expand Down