Move chrome profile to .dart_tools #316
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakemac53
reviewed
Apr 22, 2019
webdev/lib/src/serve/chrome.dart
Outdated
| @@ -62,7 +63,9 @@ class Chrome { | |||
| /// | |||
| /// Each url in [urls] will be loaded in a separate tab. | |||
| static Future<Chrome> start(List<String> urls, {int port}) async { | |||
| var dataDir = Directory.systemTemp.createTempSync(); | |||
| var dataDir = Directory.fromUri(Uri.parse(p.joinAll( | |||
There was a problem hiding this comment.
Is there a reason you can't just do Directory(p.join('.dart_tool', 'webdev', 'chrome_profile'))?
There was a problem hiding this comment.
Discussed offline. This suggestion is safe under Windows so I'll change.
jakemac53
approved these changes
Apr 22, 2019
natebosch
reviewed
Apr 22, 2019
| @@ -62,7 +63,9 @@ class Chrome { | |||
| /// | |||
| /// Each url in [urls] will be loaded in a separate tab. | |||
| static Future<Chrome> start(List<String> urls, {int port}) async { | |||
| var dataDir = Directory.systemTemp.createTempSync(); | |||
| var dataDir = Directory(p.joinAll( | |||
| [Directory.current.path, '.dart_tool', 'webdev', 'chrome_profile'])) | |||
There was a problem hiding this comment.
Have we already made some guarantee that cwd is the package root?
There was a problem hiding this comment.
grouma
added a commit
that referenced
this pull request
Apr 26, 2019
- As suggested by the Chrome docs, always use a tmp dir when passing `--remote-debugging-port` - Add graceful exit handler for daemon command - This ensures that Chrome is properly closed - Temporary pin build_daemon version to fix integration tests - Fix concurrent modification issue Closes #319 Closes #300 This reverts #322 & #316
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #297