Remove build_runner dependency and migrate client build to Dart script#2778
Open
jyameo wants to merge 4 commits intodart-lang:mainfrom
Open
Remove build_runner dependency and migrate client build to Dart script#2778jyameo wants to merge 4 commits intodart-lang:mainfrom
jyameo wants to merge 4 commits intodart-lang:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change decouples
dwdsfrompackage:build_runnerand its related dependencies (build_web_compilers,build_daemon,build,build_version, andpubspec_parse) to prepare for migration into the Dart SDK workspace.Key Changes:
build.yamlandcopy_builder.dart. Introducedtool/build.dartwhich usesdart compile jsfor building the injected client and generates version files.build_runner,build,build_daemon,build_web_compilers,build_versionandpubspec_parsefromdev_dependencies.ensure_version_test.dartandmin_sdk_test.dartto usepackage:yaml.test/build/build_script_test.dartto validate the new build script.dwds/test/integration. Note: Test fixtures and integration tests relying onbuild_daemonare temporarily broken and will be addressed post-migration.Validations:
dart run tool/build.dartcorrectly generatesclient.jsandversion.dart.Fixes dart-lang/sdk#62475