Skip to content

Run dwds tests in a copy of the sdk directory #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Feb 23, 2023
Merged

Run dwds tests in a copy of the sdk directory #1989

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
f45fd0b
Validate only needed summaries in expression_compiler_service
Jan 27, 2023
2fab3a0
Move shared test functionality into test_common package
Feb 8, 2023
e781731
Rebase on master
Feb 14, 2023
15b0837
Fix bad merge
Feb 14, 2023
6647335
Re-enable webdev weak null safety e2e tests
Feb 14, 2023
4ddc0e4
Create copy of the SDK for tests
Feb 14, 2023
f890bfa
Modify tests to run with sdk copy
Feb 15, 2023
7dc33e8
Merge with master
Feb 15, 2023
d431a3e
Cleanup
Feb 15, 2023
11aa23f
Pull out project definitions into separate file
Feb 16, 2023
230ae10
Merge branch 'master' of github.com:dart-lang/webdev into annagrin/sd…
Feb 16, 2023
caeb6f9
Add package name to the project and use it in tests
Feb 16, 2023
0acd810
Merged with master
Feb 16, 2023
8e1a7bf
Fix sdk configiuration tests
Feb 17, 2023
68bd0d3
Merged with master
Feb 18, 2023
a3a68cf
Update instance_inspection tests
Feb 18, 2023
5c6cfce
Merge with master
Feb 22, 2023
3214af1
Less changes in chrome_proxy_service.dart
Feb 22, 2023
71657bb
Merge with master
Feb 23, 2023
1dfc940
Merge with master
Feb 23, 2023
0c1d59a
Run dwds tests in a copy of sdk directory
Feb 23, 2023
2805986
Fix failing tests
Feb 23, 2023
7131028
Fix test failures
Feb 23, 2023
890f261
Merge with master
Feb 23, 2023
c762724
Cleanup
Feb 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions dwds/test/build_daemon_breakpoint_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,18 +5,20 @@
@TestOn('vm')
@Timeout(Duration(minutes: 2))

import 'package:dwds/src/services/chrome_proxy_service.dart';
import 'package:test/test.dart';
import 'package:test_common/test_sdk_configuration.dart';
import 'package:vm_service/vm_service.dart';

import 'fixtures/context.dart';
import 'fixtures/project.dart';

final context = TestContext(TestProject.testPackageWithSoundNullSafety());
void main() {
final provider = TestSdkConfigurationProvider();
tearDownAll(provider.dispose);

ChromeProxyService get service => context.service;
final context =
TestContext(TestProject.testPackageWithSoundNullSafety(), provider);

void main() {
group('shared context', () {
setUpAll(() async {
await context.setUp();
Expand All @@ -34,8 +36,10 @@ void main() {
late ScriptRef mainScript;
late String mainScriptUri;
late Stream<Event> stream;
late VmServiceInterface service;

setUp(() async {
service = context.service;
vm = await service.getVM();
isolate = await service.getIsolate(vm.isolates!.first.id!);
isolateId = isolate.id!;
Expand Down
12 changes: 7 additions & 5 deletions dwds/test/build_daemon_callstack_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,19 @@

@TestOn('vm')
@Timeout(Duration(minutes: 2))
import 'dart:async';

import 'package:dwds/src/services/chrome_proxy_service.dart';
import 'package:test/test.dart';
import 'package:test_common/logging.dart';
import 'package:test_common/test_sdk_configuration.dart';
import 'package:vm_service/vm_service.dart';

import 'fixtures/context.dart';
import 'fixtures/project.dart';

void main() {
final provider = TestSdkConfigurationProvider();
tearDownAll(provider.dispose);

group(
'shared context |',
() {
Expand All @@ -24,7 +26,7 @@ void main() {
for (var nullSafety in NullSafety.values) {
group('${nullSafety.name} null safety |', () {
final project = TestProject.testPackage(nullSafety: nullSafety);
final context = TestContext(project);
final context = TestContext(project, provider);

setUpAll(() async {
setCurrentLogWriter(debug: debug);
Expand All @@ -40,7 +42,7 @@ void main() {
});

group('callStack |', () {
late ChromeProxyService service;
late VmServiceInterface service;
VM vm;
late Isolate isolate;
ScriptList scripts;
Expand All @@ -58,7 +60,7 @@ void main() {
await service.streamListen('Debug');
stream = service.onEvent('Debug');

final testPackage = project.packageName;
final testPackage = context.project.packageName;
mainScript = scripts.scripts!
.firstWhere((each) => each.uri!.contains('main.dart'));
testLibraryScript = scripts.scripts!.firstWhere((each) =>
Expand Down
5 changes: 5 additions & 0 deletions dwds/test/build_daemon_circular_evaluate_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
@Timeout(Duration(minutes: 2))

import 'package:test/test.dart';
import 'package:test_common/test_sdk_configuration.dart';

import 'evaluate_circular_common.dart';
import 'fixtures/context.dart';
Expand All @@ -15,9 +16,13 @@ void main() async {
// Enable verbose logging for debugging.
final debug = false;

final provider = TestSdkConfigurationProvider(verbose: debug);
tearDownAll(provider.dispose);

for (var nullSafety in NullSafety.values) {
group('${nullSafety.name} null safety |', () {
testAll(
provider: provider,
compilationMode: CompilationMode.buildDaemon,
nullSafety: nullSafety,
debug: debug,
Expand Down
5 changes: 5 additions & 0 deletions dwds/test/build_daemon_evaluate_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
@Timeout(Duration(minutes: 2))

import 'package:test/test.dart';
import 'package:test_common/test_sdk_configuration.dart';

import 'evaluate_common.dart';
import 'fixtures/context.dart';
Expand All @@ -15,9 +16,13 @@ void main() async {
// Enable verbose logging for debugging.
final debug = false;

final provider = TestSdkConfigurationProvider(verbose: debug);
tearDownAll(provider.dispose);

for (var nullSafety in NullSafety.values) {
group('${nullSafety.name} null safety |', () {
testAll(
provider: provider,
compilationMode: CompilationMode.buildDaemon,
nullSafety: nullSafety,
debug: debug,
Expand Down
Loading