Skip to content

Run dwds tests in a copy of the sdk directory #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Feb 23, 2023
Merged

Run dwds tests in a copy of the sdk directory #1989

merged 25 commits into from
Feb 23, 2023

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Feb 23, 2023 •
edited
Loading

Test-only changes

Run tests using a copy of the Dart SDK directory so we don't pollute the default one with generated assets.

  • Replace old TestSdkConfigurationProvider by the copying one.
  • Pass a TestSdkConfigurationProvider toTestContext contsructor.
  • Make dwds tests create and dispose of the SDK configuration provider as needed.
  • Make sure all commands that are run from tests use dart executable from the SDK copy.

Closes: #1985
Towards: #1878

Anna Gringauze added 21 commits February 13, 2023 15:01
Validate only needed summaries in expression_compiler_service
f45fd0b
Move shared test functionality into test_common package
2fab3a0
Rebase on master
e781731
Fix bad merge
15b0837
Re-enable webdev weak null safety e2e tests
6647335
Create copy of the SDK for tests
4ddc0e4
Modify tests to run with sdk copy
f890bfa
Merge with master
7dc33e8
Cleanup
d431a3e
Pull out project definitions into separate file
11aa23f
Merge branch 'master' of github.com:dart-lang/webdev into annagrin/sd…
230ae10 
…k-copy-for-tests2
Add package name to the project and use it in tests
caeb6f9
Merged with master
0acd810
Fix sdk configiuration tests
8e1a7bf
Merged with master
68bd0d3
Update instance_inspection tests
a3a68cf
Merge with master
5c6cfce
Less changes in chrome_proxy_service.dart
3214af1
Merge with master
71657bb
Merge with master
1dfc940
Run dwds tests in a copy of sdk directory
0c1d59a
@annagrin annagrin mentioned this pull request Feb 23, 2023
Closed
13 tasks
@annagrin annagrin requested a review from elliette February 23, 2023 18:46
@annagrin annagrin mentioned this pull request Feb 23, 2023
Closed
annagrin
annagrin commented Feb 23, 2023
View reviewed changes
@annagrin annagrin merged commit 28a090e into dart-lang:master Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliette elliette elliette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run tests in a copy of the sdk directory
2 participants
@annagrin @elliette