[enhanced-parts] don’t report use_string_in_part_of_directives

As this will produce a diagnostic, we don't want to double-report.

Fixes: dart-lang/linter#5026

Change-Id: Ia745875a35d3c83c6fecf2a892b65a91c91fbb4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/376760
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>

pkg/analysis_server/test/src/services/correction/fix/replace_with_part_of_uri_test.dart

@@ -25,17 +25,26 @@ class ReplaceWithPartOfUriTest extends FixProcessorLintTest {
 
   Future<void> test_packageLib_nestedDirectory() async {
     newFile('$testPackageLibPath/nested/a.dart', r'''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 library my.lib;
 part '../test.dart';
 ''');
 
     await resolveTestCode('''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 part of my.lib;
 
 class A {}
 ''');
 
     await assertHasFix('''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 part of 'nested/a.dart';
 
 class A {}
@@ -44,19 +53,28 @@ class A {}
 
   Future<void> test_packageLib_parentDirectory() async {
     newFile('$testPackageLibPath/a.dart', r'''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 library my.lib;
 part 'nested/test.dart';
 ''');
 
     testFilePath = getFile('$testPackageLibPath/nested/test.dart').path;
 
     await resolveTestCode('''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 part of my.lib;
 
 class A {}
 ''');
 
     await assertHasFix('''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 part of '../a.dart';
 
 class A {}
@@ -65,17 +83,26 @@ class A {}
 
   Future<void> test_packageLib_sameDirectory() async {
     newFile('$testPackageLibPath/a.dart', r'''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 library my.lib;
 part 'test.dart';
 ''');
 
     await resolveTestCode('''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 part of my.lib;
 
 class A {}
 ''');
 
     await assertHasFix('''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 part of 'a.dart';
 
 class A {}
@@ -84,19 +111,28 @@ class A {}
 
   Future<void> test_packageLib_siblingDirectory() async {
     newFile('$testPackageLibPath/first/a.dart', r'''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 library my.lib;
 part '../second/test.dart';
 ''');
 
     testFilePath = getFile('$testPackageLibPath/second/test.dart').path;
 
     await resolveTestCode('''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 part of my.lib;
 
 class A {}
 ''');
 
     await assertHasFix('''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 part of '../first/a.dart';
 
 class A {}

pkg/linter/lib/src/rules/use_string_in_part_of_directives.dart

@@ -2,8 +2,10 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
+import 'package:analyzer/dart/analysis/features.dart';
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
+import 'package:analyzer/src/lint/linter.dart'; //ignore: implementation_imports
 
 import '../analyzer.dart';
 
@@ -51,8 +53,10 @@ class UseStringInPartOfDirectives extends LintRule {
     NodeLintRegistry registry,
     LinterContext context,
   ) {
-    var visitor = _Visitor(this);
-    registry.addPartOfDirective(this, visitor);
+    if (!context.hasEnancedPartsFeatureEnabled) {
+      var visitor = _Visitor(this);
+      registry.addPartOfDirective(this, visitor);
+    }
   }
 }
 
@@ -68,3 +72,11 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
   }
 }
+
+extension on LinterContext {
+  bool get hasEnancedPartsFeatureEnabled {
+    var self = this;
+    return self is LinterContextWithResolvedResults &&
+        self.libraryElement.featureSet.isEnabled(Feature.enhanced_parts);
+  }
+}

pkg/linter/test/rules/all.dart

@@ -286,6 +286,8 @@ import 'use_rethrow_when_possible_test.dart' as use_rethrow_when_possible;
 import 'use_setters_to_change_properties_test.dart'
     as use_setters_to_change_properties;
 import 'use_string_buffers_test.dart' as use_string_buffers;
+import 'use_string_in_part_of_directives_test.dart'
+    as use_string_in_part_of_directives;
 import 'use_super_parameters_test.dart' as use_super_parameters;
 import 'use_test_throws_matchers_test.dart' as use_test_throws_matchers;
 import 'use_to_and_as_if_applicable_test.dart' as use_to_and_as_if_applicable;
@@ -498,6 +500,7 @@ void main() {
   use_rethrow_when_possible.main();
   use_setters_to_change_properties.main();
   use_string_buffers.main();
+  use_string_in_part_of_directives.main();
   use_super_parameters.main();
   use_test_throws_matchers.main();
   use_to_and_as_if_applicable.main();

pkg/linter/test/rules/use_string_in_part_of_directives.dart → pkg/linter/test/rules/use_string_in_part_of_directives_test.dart

@@ -22,15 +22,31 @@ class UseStringInPartOfDirectivesTest extends LintRuleTest {
 
   test_part_of_with_library_name() async {
     newFile('$testPackageRootPath/lib/lib.dart', '''
+library lib;
+part '$testFileName';
+''');
+    await assertNoDiagnostics(r'''
+part of lib;
+''');
+  }
+
+  test_part_of_with_library_name_preEnhancedParts() async {
+    newFile('$testPackageRootPath/lib/lib.dart', '''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 library lib;
 part '$testFileName';
 ''');
     await assertDiagnostics(
       r'''
+// @dart = 3.4
+// (pre enhanced-parts)
+
 part of lib;
 ''',
       [
-        lint(0, 12),
+        lint(40, 12),
       ],
     );
   }