Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[enhanced-parts] support for use_string_in_part_of_directives #5026

Closed
Tracked by #5024
pq opened this issue Jul 18, 2024 · 1 comment
Closed
Tracked by #5024

[enhanced-parts] support for use_string_in_part_of_directives #5026

pq opened this issue Jul 18, 2024 · 1 comment
Assignees
@pq
Labels
new-language-feature P1 A high priority bug; for example, a single project is unusable or has many test failures set-core Affects a rule in the core Dart rule set type-enhancement A request for a change that isn't a bug

Comments

@pq
Copy link
Member

pq commented Jul 18, 2024 •
edited
Loading

If I'm understanding it right, with this feature enabled, where this lint currently reports will become a diagnostic. In order to not over-report, it seems we should make this a no-op whenever Feature.enhanced_parts is enabled.

https://github.com/dart-lang/language/blob/main/working/augmentation-libraries/parts_with_imports.md#pre-feature-code-interaction-and-migration
@pq pq mentioned this issue Jul 18, 2024
Open
@pq pq changed the title [parts with imports] evaluate support for use_string_in_part_of_directives [parts with imports] support for use_string_in_part_of_directives Jul 18, 2024
@github-actions github-actions bot added the set-core Affects a rule in the core Dart rule set label Jul 18, 2024
@pq pq self-assigned this Jul 18, 2024
@pq pq added new-language-feature P1 A high priority bug; for example, a single project is unusable or has many test failures labels Jul 18, 2024
@pq pq changed the title [parts with imports] support for use_string_in_part_of_directives [enhanced parts] support for use_string_in_part_of_directives Jul 18, 2024
@pq pq changed the title [enhanced parts] support for use_string_in_part_of_directives [enhanced-parts] support for use_string_in_part_of_directives Jul 18, 2024
@srawlins srawlins added the type-enhancement A request for a change that isn't a bug label Jul 19, 2024
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Jul 19, 2024
@pq
[enhanced-parts] don’t report use_string_in_part_of_directives
7282f03 
As this will produce a diagnostic, we don't want to double-report.

Fixes: dart-lang/linter#5026

Change-Id: Ia745875a35d3c83c6fecf2a892b65a91c91fbb4d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/376760
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
@pq
Copy link
Member Author

pq commented Jul 19, 2024

Fixed w/ dart-lang/sdk@7282f03

@pq pq closed this as completed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pq pq

Labels
new-language-feature P1 A high priority bug; for example, a single project is unusable or has many test failures set-core Affects a rule in the core Dart rule set type-enhancement A request for a change that isn't a bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pq @srawlins