[hooks_runner] Support building assets for dev deps

pkgs/code_assets/analysis_options.yaml

@@ -12,6 +12,7 @@ analyzer:
 
 linter:
   rules:
+    - avoid_positional_boolean_parameters
     - dangling_library_doc_comments
     - prefer_const_declarations
     - prefer_expression_function_bodies

pkgs/data_assets/analysis_options.yaml

@@ -12,6 +12,7 @@ analyzer:
 
 linter:
   rules:
+    - avoid_positional_boolean_parameters
     - dangling_library_doc_comments
     - prefer_const_declarations
     - prefer_expression_function_bodies

pkgs/hooks/analysis_options.yaml

@@ -12,6 +12,7 @@ analyzer:
 
 linter:
   rules:
+    - avoid_positional_boolean_parameters
     - dangling_library_doc_comments
     - prefer_const_declarations
     - prefer_expression_function_bodies

pkgs/hooks_runner/CHANGELOG.md

@@ -1,3 +1,8 @@
+## 0.21.0
+
+* Add `includeDevDependencies` param to `BuildLayout` to enable building the
+  assets for dev dependencies of the `runPackage`.
+
 ## 0.20.2
 
 * Add `dart:developer` `TimelineEvent`s to enable performance tracing for

pkgs/hooks_runner/analysis_options.yaml

@@ -12,6 +12,7 @@ analyzer:
 
 linter:
   rules:
+    - avoid_positional_boolean_parameters
     - dangling_library_doc_comments
     - prefer_const_declarations
     - prefer_expression_function_bodies

pkgs/hooks_runner/lib/src/build_runner/build_planner.dart

@@ -52,6 +52,8 @@ class NativeAssetsBuildPlanner {
     final packageGraphJson = await packageGraphJsonFile.readAsString();
     final packageGraph = PackageGraph.fromPackageGraphJsonString(
       packageGraphJson,
+      packageLayout.runPackageName,
+      includeDevDependencies: packageLayout.includeDevDependencies,
     );
     final packageGraphFromRunPackage = packageGraph.subGraph(
       packageLayout.runPackageName,
@@ -182,12 +184,21 @@ class PackageGraph {
 
   PackageGraph(this.map);
 
-  factory PackageGraph.fromPackageGraphJsonString(String json) =>
-      PackageGraph.fromPackageGraphJson(
-        jsonDecode(json) as Map<dynamic, dynamic>,
-      );
+  factory PackageGraph.fromPackageGraphJsonString(
+    String json,
+    String runPackageName, {
+    required bool includeDevDependencies,
+  }) => PackageGraph.fromPackageGraphJson(
+    jsonDecode(json) as Map<dynamic, dynamic>,
+    runPackageName,
+    includeDevDependencies: includeDevDependencies,
+  );
 
-  factory PackageGraph.fromPackageGraphJson(Map<dynamic, dynamic> map) {
+  factory PackageGraph.fromPackageGraphJson(
+    Map<dynamic, dynamic> map,
+    String runPackageName, {
+    required bool includeDevDependencies,
+  }) {
     final result = <String, List<String>>{};
     final packages = map['packages'] as List<dynamic>;
     for (final package in packages) {
@@ -196,6 +207,14 @@ class PackageGraph {
       final dependencies = (package_['dependencies'] as List<dynamic>)
           .whereType<String>()
           .toList();
+      if (name == runPackageName && includeDevDependencies) {
+        final devDependencies =
+            (package_['devDependencies'] as List<dynamic>?)
+                ?.whereType<String>()
+                .toList() ??
+            [];
+        dependencies.addAll(devDependencies);
+      }
       result[name] = dependencies;
     }
     return PackageGraph(result);

pkgs/hooks_runner/lib/src/package_layout/package_layout.dart

@@ -34,36 +34,52 @@ class PackageLayout {
   /// Only assets of transitive dependencies of [runPackageName] are built.
   final String runPackageName;
 
+  /// Include the dev dependencies of [runPackageName].
+  final bool includeDevDependencies;
+
   PackageLayout._(
     this.packageConfig,
     this.packageConfigUri,
-    this.runPackageName,
-  );
+    this.runPackageName, {
+    required this.includeDevDependencies,
+  });
 
   factory PackageLayout.fromPackageConfig(
     FileSystem fileSystem,
     PackageConfig packageConfig,
     Uri packageConfigUri,
-    String runPackageName,
-  ) {
+    String runPackageName, {
+    required bool includeDevDependencies,
+  }) {
     assert(fileSystem.file(packageConfigUri).existsSync());
     packageConfigUri = packageConfigUri.normalizePath();
-    return PackageLayout._(packageConfig, packageConfigUri, runPackageName);
+    return PackageLayout._(
+      packageConfig,
+      packageConfigUri,
+      runPackageName,
+      includeDevDependencies: includeDevDependencies,
+    );
   }
 
   static Future<PackageLayout> fromWorkingDirectory(
     FileSystem fileSystem,
     Uri workingDirectory,
-    String runPackgeName,
-  ) async {
+    String runPackageName, {
+    required bool includeDevDependencies,
+  }) async {
     workingDirectory = workingDirectory.normalizePath();
     final packageConfigUri = await findPackageConfig(
       fileSystem,
       workingDirectory,
     );
     assert(await fileSystem.file(packageConfigUri).exists());
     final packageConfig = await loadPackageConfigUri(packageConfigUri!);
-    return PackageLayout._(packageConfig, packageConfigUri, runPackgeName);
+    return PackageLayout._(
+      packageConfig,
+      packageConfigUri,
+      runPackageName,
+      includeDevDependencies: includeDevDependencies,
+    );
   }
 
   static Future<Uri?> findPackageConfig(

pkgs/hooks_runner/pubspec.yaml

@@ -2,7 +2,7 @@ name: hooks_runner
 description: >-
   This package is the backend that invokes build hooks.
 
-version: 0.20.2
+version: 0.21.0
 
 repository: https://github.com/dart-lang/native/tree/main/pkgs/hooks_runner
 

pkgs/hooks_runner/test/build_runner/build_planner_test.dart

@@ -25,6 +25,7 @@ void main() async {
         const LocalFileSystem(),
         nativeAddUri,
         'native_add',
+        includeDevDependencies: false,
       );
       final nativeAssetsBuildPlanner =
           await NativeAssetsBuildPlanner.fromPackageConfigUri(
@@ -60,6 +61,7 @@ void main() async {
           const LocalFileSystem(),
           nativeAddUri,
           runPackageName,
+          includeDevDependencies: false,
         );
         final nativeAssetsBuildPlanner =
             await NativeAssetsBuildPlanner.fromPackageConfigUri(
@@ -76,4 +78,36 @@ void main() async {
       });
     });
   }
+
+  for (final includeDevDependencies in [true, false]) {
+    test('includeDevDependencies $includeDevDependencies', () async {
+      const runPackageName = 'dev_dependency_with_hook';
+      await inTempDir((tempUri) async {
+        await copyTestProjects(targetUri: tempUri);
+        final nativeAddUri = tempUri.resolve('$runPackageName/');
+
+        // First, run `pub get`, we need pub to resolve our dependencies.
+        await runPubGet(workingDirectory: nativeAddUri, logger: logger);
+
+        final packageLayout = await PackageLayout.fromWorkingDirectory(
+          const LocalFileSystem(),
+          nativeAddUri,
+          runPackageName,
+          includeDevDependencies: includeDevDependencies,
+        );
+        final nativeAssetsBuildPlanner =
+            await NativeAssetsBuildPlanner.fromPackageConfigUri(
+              packageConfigUri: nativeAddUri.resolve(
+                '.dart_tool/package_config.json',
+              ),
+              dartExecutable: Uri.file(Platform.resolvedExecutable),
+              logger: logger,
+              packageLayout: packageLayout,
+              fileSystem: const LocalFileSystem(),
+            );
+        final buildPlan = await nativeAssetsBuildPlanner.makeBuildHookPlan();
+        expect(buildPlan.success.length, includeDevDependencies ? 1 : 0);
+      });
+    });
+  }
 }

pkgs/hooks_runner/test/build_runner/build_runner_reusability_test.dart

@@ -27,6 +27,7 @@ void main() async {
         const LocalFileSystem(),
         packageUri,
         packageName,
+        includeDevDependencies: false,
       );
       final buildRunner = NativeAssetsBuildRunner(
         logger: logger,

pkgs/hooks_runner/test/build_runner/concurrency_shared_test_helper.dart

@@ -25,6 +25,7 @@ void main(List<String> args) async {
     const LocalFileSystem(),
     packageUri,
     packageName,
+    includeDevDependencies: false,
   );
   final result =
       await NativeAssetsBuildRunner(

pkgs/hooks_runner/test/build_runner/concurrency_test_helper.dart

@@ -29,6 +29,7 @@ void main(List<String> args) async {
     const LocalFileSystem(),
     packageUri,
     packageName,
+    includeDevDependencies: false,
   );
   final result =
       await NativeAssetsBuildRunner(

pkgs/hooks_runner/test/build_runner/helpers.dart

@@ -86,6 +86,7 @@ Future<Result<BuildResult, HooksRunnerFailure>> build(
     const LocalFileSystem(),
     packageUri,
     runPackageName_,
+    includeDevDependencies: false,
   );
   return await runWithLog(capturedLogs, () async {
     final result =
@@ -164,6 +165,7 @@ Future<Result<LinkResult, HooksRunnerFailure>> link(
     const LocalFileSystem(),
     packageUri,
     runPackageName_,
+    includeDevDependencies: false,
   );
   return await runWithLog(capturedLogs, () async {
     final result =
@@ -235,6 +237,7 @@ Future<(BuildResult?, LinkResult?)> buildAndLink(
     const LocalFileSystem(),
     packageUri,
     runPackageName_,
+    includeDevDependencies: false,
   );
   final buildRunner = NativeAssetsBuildRunner(
     logger: logger,

pkgs/hooks_runner/test/build_runner/package_layout_test.dart

@@ -23,12 +23,14 @@ void main() async {
         fileSystem,
         nativeAddUri,
         'native_add',
+        includeDevDependencies: false,
       );
       final packageLayout2 = PackageLayout.fromPackageConfig(
         fileSystem,
         packageLayout.packageConfig,
         packageLayout.packageConfigUri,
         'native_add',
+        includeDevDependencies: false,
       );
       expect(packageLayout.packageConfigUri, packageLayout2.packageConfigUri);
     });

pkgs/hooks_runner/test/build_runner/pub_workspace_test.dart

@@ -126,6 +126,7 @@ dependency_overrides:
         fileSystem,
         packageUri,
         runPackageName,
+        includeDevDependencies: false,
       );
       final builderNoHook = NativeAssetsBuildRunner(
         logger: logger,

pkgs/hooks_runner/test_data/dev_dependency_with_hook/pubspec.yaml

@@ -0,0 +1,19 @@
+name: dev_dependency_with_hook
+description: Has a dev dependency with hook
+version: 0.1.0
+
+publish_to: none
+
+resolution: workspace
+
+environment:
+  sdk: '>=3.8.0 <4.0.0'
+
+dependencies: {}
+
+dev_dependencies:
+  ffigen: ^18.0.0
+  lints: ^5.1.1
+  native_add:
+    path: ../native_add/
+  test: ^1.25.15

pkgs/hooks_runner/test_data/dev_dependency_with_hook/test/my_test.dart

@@ -0,0 +1,13 @@
+// Copyright (c) 2025, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+import 'package:native_add/native_add.dart';
+import 'package:test/test.dart';
+
+void main() {
+  test('native add test', () {
+    final result = add(4, 6);
+    expect(result, equals(10));
+  });
+}

pkgs/hooks_runner/test_data/manifest.yaml

@@ -34,6 +34,8 @@
 - depend_on_fail_build/pubspec.yaml
 - depend_on_fail_build_app/bin/depend_on_fail_build_app.dart
 - depend_on_fail_build_app/pubspec.yaml
+- dev_dependency_with_hook/pubspec.yaml
+- dev_dependency_with_hook/test/my_test.dart
 - drop_dylib_link/bin/drop_dylib_link.dart
 - drop_dylib_link/hook/build.dart
 - drop_dylib_link/hook/link.dart

pkgs/hooks_runner/test_data/manifest_generator.dart

@@ -6,9 +6,11 @@ import 'dart:io';
 
 void main(List<String> args) async {
   final testDataDirectory = Directory.fromUri(Platform.script.resolve('.'));
-  updateManifest(testDataDirectory, false);
+  updateManifest(testDataDirectory, allowPartialProjects: false);
   final all = testDataDirectory.listSync(recursive: true);
-  all.whereType<Directory>().forEach((e) => updateManifest(e, true));
+  all.whereType<Directory>().forEach(
+    (e) => updateManifest(e, allowPartialProjects: true),
+  );
 }
 
 const denyList = [
@@ -32,7 +34,7 @@ const partialProjects = [
   'simple_link_change_asset',
 ];
 
-void updateManifest(Directory directory, bool allowPartialProjects) {
+void updateManifest(Directory directory, {required bool allowPartialProjects}) {
   final manifestFile = File.fromUri(directory.uri.resolve('manifest.yaml'));
   if (!manifestFile.existsSync()) {
     return;

pkgs/hooks_runner/test_data/native_add_version_skew/analysis_options.yaml

@@ -10,6 +10,7 @@ analyzer:
 
 linter:
   rules:
+    - avoid_positional_boolean_parameters
     - dangling_library_doc_comments
     - prefer_const_declarations
     - prefer_expression_function_bodies

pkgs/hooks_runner/test_data/native_add_version_skew_2/analysis_options.yaml

@@ -10,6 +10,7 @@ analyzer:
 
 linter:
   rules:
+    - avoid_positional_boolean_parameters
     - dangling_library_doc_comments
     - prefer_const_declarations
     - prefer_expression_function_bodies

pkgs/json_syntax_generator/analysis_options.yaml

@@ -12,6 +12,7 @@ analyzer:
 
 linter:
   rules:
+    - avoid_positional_boolean_parameters
     - dangling_library_doc_comments
     - prefer_const_declarations
     - prefer_expression_function_bodies

pkgs/native_toolchain_c/analysis_options.yaml

@@ -12,6 +12,7 @@ analyzer:
 
 linter:
   rules:
+    - avoid_positional_boolean_parameters
     - dangling_library_doc_comments
     - prefer_const_declarations
     - prefer_expression_function_bodies

pkgs/repo_lint_rules/analysis_options.yaml

@@ -12,6 +12,7 @@ analyzer:
 
 linter:
   rules:
+    - avoid_positional_boolean_parameters
     - dangling_library_doc_comments
     - prefer_const_declarations
     - prefer_expression_function_bodies

pubspec.yaml

@@ -16,6 +16,7 @@ workspace:
   - pkgs/hooks_runner/test_data/dart_app
   - pkgs/hooks_runner/test_data/depend_on_fail_build
   - pkgs/hooks_runner/test_data/depend_on_fail_build_app
+  - pkgs/hooks_runner/test_data/dev_dependency_with_hook
   - pkgs/hooks_runner/test_data/drop_dylib_link
   - pkgs/hooks_runner/test_data/fail_build
   - pkgs/hooks_runner/test_data/fail_on_os_sdk_version