-
Notifications
You must be signed in to change notification settings - Fork 69
[hooks_runner] Support building assets for dev deps #2342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Package publishing
Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation. |
PR HealthChangelog Entry ✔️
Changes to files need to be accounted for in their respective changelogs. API leaks ✔️The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.
License Headers ✔️
All source files should start with a license header. Unrelated files missing license headers
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -25,6 +25,7 @@ void main() async { | |||
const LocalFileSystem(), | |||
nativeAddUri, | |||
'native_add', | |||
false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe upgrade includeDevDependencies
to a named parameter everywhere to make this more readable?
See also https://dart.dev/effective-dart/design#avoid-positional-boolean-parameters.
There's also a lint for this: avoid_positional_boolean_parameters
Bug:
dev_dependencies
indart test
andflutter test
#2312Breaks the public API of the
package:hooks_runner
, needs a manual roll into Dart and Flutter.