Skip to content

[hooks_runner] Support building assets for dev deps #2342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2025
Merged

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Jun 2, 2025

Bug:

Breaks the public API of the package:hooks_runner, needs a manual roll into Dart and Flutter.

Copy link

github-actions bot commented Jun 2, 2025

Package publishing

Package Version Status Publish tag (post-merge)
package:code_assets 0.19.3 already published at pub.dev
package:data_assets 0.19.1 already published at pub.dev
package:ffi 2.1.4 already published at pub.dev
package:ffigen 19.1.0-wip WIP (no publish necessary)
package:hooks 0.19.3 already published at pub.dev
package:hooks_runner 0.21.0 ready to publish hooks_runner-v0.21.0
package:jni 0.14.2 already published at pub.dev
package:jnigen 0.14.2 already published at pub.dev
package:native_doc_dartifier 0.0.1-pre already published at pub.dev
package:native_toolchain_c 0.16.2 already published at pub.dev
package:objective_c 8.1.0-wip WIP (no publish necessary)
package:swift2objc 0.0.1-wip WIP (no publish necessary)
package:swiftgen 0.0.1-wip WIP (no publish necessary)

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@dcharkes dcharkes requested a review from goderbauer June 2, 2025 18:15
@dcharkes dcharkes marked this pull request as ready for review June 2, 2025 18:15
Copy link

github-actions bot commented Jun 2, 2025

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

API leaks ✔️

The following packages contain symbols visible in the public API, but not exported by the library. Export these symbols or remove them from your publicly visible API.

Package Leaked API symbols
License Headers ✔️
// Copyright (c) 2025, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
Files
no missing headers

All source files should start with a license header.

Unrelated files missing license headers
Files
pkgs/jni/lib/src/third_party/generated_bindings.dart
pkgs/native_doc_dartifier/example/native_doc_dartifier_example.dart
pkgs/native_doc_dartifier/lib/native_doc_dartifier.dart
pkgs/native_doc_dartifier/lib/src/native_doc_dartifier_base.dart
pkgs/native_doc_dartifier/test/native_doc_dartifier_test.dart
pkgs/objective_c/lib/src/ns_input_stream.dart

@dcharkes dcharkes requested a review from mosuem June 3, 2025 06:53
Copy link
Contributor

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -25,6 +25,7 @@ void main() async {
const LocalFileSystem(),
nativeAddUri,
'native_add',
false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe upgrade includeDevDependencies to a named parameter everywhere to make this more readable?

See also https://dart.dev/effective-dart/design#avoid-positional-boolean-parameters.

There's also a lint for this: avoid_positional_boolean_parameters

@auto-submit auto-submit bot merged commit 7f5bfa6 into main Jun 3, 2025
50 checks passed
@auto-submit auto-submit bot deleted the dev-deps branch June 3, 2025 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants