Skip to content

Fix printing of log messages on test failures #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 18 additions & 7 deletions pkgs/native_assets_builder/test/helpers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -157,21 +157,32 @@ Future<void> copyTestProjects({
}

/// Logger that outputs the full trace when a test fails.
final logger = Logger('')
..level = Level.ALL
..onRecord.listen((record) {
printOnFailure(record.message);
});
Logger get logger => _logger ??= () {
// A new logger is lazily created for each test so that the messages
// captured by printOnFailure are scoped to the correct test.
addTearDown(() => _logger = null);
return _createTestLogger();
}();

Logger? _logger;

Logger createCapturingLogger(
List<String> capturedMessages, {
Level level = Level.ALL,
}) =>
_createTestLogger(capturedMessages: capturedMessages, level: level);

Logger _createTestLogger({
List<String>? capturedMessages,
Level level = Level.ALL,
}) =>
Logger('')
..level = level
..onRecord.listen((record) {
printOnFailure(record.message);
capturedMessages.add(record.message);
printOnFailure(
'${record.level.name}: ${record.time}: ${record.message}',
);
capturedMessages?.add(record.message);
});

final dartExecutable = File(Platform.resolvedExecutable).uri;
4 changes: 3 additions & 1 deletion pkgs/native_assets_cli/example/native_add_library/build.dart
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,9 @@ void main(List<String> args) async {
// `package:native_toolchain_c` will output the dynamic or static libraries it built,
// what files it accessed (for caching the build), etc.
buildOutput: buildOutput,
logger: Logger('')..onRecord.listen((record) => print(record.message)),
logger: Logger('')
..level = Level.ALL
..onRecord.listen((record) => print(record.message)),
);

// Write the output according to the native assets protocol so that Dart or
Expand Down
20 changes: 13 additions & 7 deletions pkgs/native_toolchain_c/test/helpers.dart
Original file line number Diff line number Diff line change
Expand Up @@ -54,17 +54,23 @@ Future<Uri> tempDirForTest({String? prefix, bool keepTemp = false}) async {
}

/// Logger that outputs the full trace when a test fails.
final logger = Logger('')
..level = Level.ALL
..onRecord.listen((record) {
printOnFailure('${record.level.name}: ${record.time}: ${record.message}');
});
Logger get logger => _logger ??= () {
// A new logger is lazily created for each test so that the messages
// captured by printOnFailure are scoped to the correct test.
addTearDown(() => _logger = null);
return _createTestLogger();
}();

Logger? _logger;

Logger createCapturingLogger(List<String> capturedMessages) =>
_createTestLogger(capturedMessages: capturedMessages);

Logger createCapturingLogger(List<String> capturedMessages) => Logger('')
Logger _createTestLogger({List<String>? capturedMessages}) => Logger('')
..level = Level.ALL
..onRecord.listen((record) {
printOnFailure('${record.level.name}: ${record.time}: ${record.message}');
capturedMessages.add(record.message);
capturedMessages?.add(record.message);
});

/// Test files are run in a variety of ways, find this package root in all.
Expand Down