Fix printing of log messages on test failures #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
package:hooks
package:native_toolchain_c
package:hooks_runner
labels
|
Thanks @blaugold ! |
dcharkes
approved these changes
Oct 3, 2023
dcharkes
reviewed
Oct 3, 2023
| printOnFailure(record.message); | ||
| }); | ||
| Logger get logger => _logger ??= () { | ||
| // We lazily create a new logger for each test so that the messages |
|
auto label is removed for dart-lang/native/147, due to This PR has not met approval requirements for merging. You are not a member of dart-team and need 1 more review(s) in order to merge this PR.
|
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
HosseinYousefi
pushed a commit
that referenced
this pull request
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The global singleton
loggerthat was used before associated all log messages with the first test that accessed it.The issue was that calling
onRecord.listen()captured theZoneof the first access ofloggerand thus of the first test that useslogger.printOnFailurein turn usesZones to associate messages with a specific test.