Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PackageLayout constructor for already parsed PackageConfig #126

Merged
merged 1 commit into from
Sep 12, 2023
Merged

PackageLayout constructor for already parsed PackageConfig #126

merged 1 commit into from
Sep 12, 2023

Conversation

dcharkes
Copy link
Collaborator

Provide a constructor for PackageLayout that does not require reading and reparsing the package config file.

Context:

@github-actions
Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:native_assets_builder 0.2.1 ready to publish native_assets_builder-v0.2.1
package:native_assets_cli 0.2.0 already published at pub.dev
package:native_toolchain_c 0.2.3 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

HosseinYousefi
HosseinYousefi approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dcharkes!

@dcharkes dcharkes merged commit a7cd31e into main Sep 12, 2023
17 checks passed
@dcharkes dcharkes deleted the package-layout branch September 12, 2023 07:33
@dcharkes dcharkes mentioned this pull request Sep 12, 2023
Merged
HosseinYousefi added a commit that referenced this pull request Nov 16, 2023
@HosseinYousefi
[jnigen] JniX to JX rename (#126)
f77a3d7 
Closed #124.
Closed #125.

* Added `JPrimitive` and its subclasses instead of using the typedefs from `ffi` directly.
* Renamed `JniObject`, `JniString`, and ... to the shorter `JObject`, JString`, and ...
* Made tests more robust by deleting the objects in an arena.
HosseinYousefi added a commit that referenced this pull request Nov 16, 2023
@HosseinYousefi
[jnigen] JniX to JX rename (#126)
1c95d14 
Closed #124.
Closed #125.

* Added `JPrimitive` and its subclasses instead of using the typedefs from `ffi` directly.
* Renamed `JniObject`, `JniString`, and ... to the shorter `JObject`, JString`, and ...
* Made tests more robust by deleting the objects in an arena.
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@dcharkes
PackageLayout constructor for already parsed PackageConfig (#126)
11b4a64
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HosseinYousefi HosseinYousefi HosseinYousefi approved these changes

Assignees
No one assigned
Labels
package:native_assets_builder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcharkes @HosseinYousefi