Skip to content

[native_toolchain_c] Fix MSVC x86 toolchain resolution #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 11, 2023
Merged

[native_toolchain_c] Fix MSVC x86 toolchain resolution #124

merged 2 commits into from
Sep 11, 2023

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Sep 7, 2023

Closes: #123

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Package publishing

Package Version Status Publish tag (post-merge)
package:native_toolchain_c 0.2.3 ready to publish native_toolchain_c-v0.2.3
package:native_assets_cli 0.2.0 already published at pub.dev
package:native_assets_builder 0.2.0 already published at pub.dev

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@HosseinYousefi
Copy link
Member

Some checks seem to be failing.

@coveralls
Copy link

Coverage Status

coverage: 98.184%. remained the same when pulling a2f98e1 on fix-glob into 07e1de5 on main.

@dcharkes
Copy link
Collaborator Author

Some checks seem to be failing.

Glob requires forward slashes, I removed that logic accidentally (of course that's not part of glob escaping...)

HosseinYousefi
HosseinYousefi approved these changes Sep 11, 2023
View reviewed changes
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dcharkes!

@dcharkes dcharkes merged commit 9f24b64 into main Sep 11, 2023
@dcharkes dcharkes deleted the fix-glob branch September 11, 2023 11:31
HosseinYousefi added a commit that referenced this pull request Nov 16, 2023
@HosseinYousefi
[jnigen] JniX to JX rename (#126)
f77a3d7 
Closed #124.
Closed #125.

* Added `JPrimitive` and its subclasses instead of using the typedefs from `ffi` directly.
* Renamed `JniObject`, `JniString`, and ... to the shorter `JObject`, JString`, and ...
* Made tests more robust by deleting the objects in an arena.
HosseinYousefi added a commit that referenced this pull request Nov 16, 2023
@HosseinYousefi
[jnigen] JniX to JX rename (#126)
1c95d14 
Closed #124.
Closed #125.

* Added `JPrimitive` and its subclasses instead of using the typedefs from `ffi` directly.
* Renamed `JniObject`, `JniString`, and ... to the shorter `JObject`, JString`, and ...
* Made tests more robust by deleting the objects in an arena.
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@dcharkes
[native_toolchain_c] Fix MSVC x86 toolchain resolution (#124)
47a51c5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HosseinYousefi HosseinYousefi HosseinYousefi approved these changes

Assignees
No one assigned
Labels
package:native_toolchain_c
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[native_toolchain_c] Visual studio resolution fails due to ( in path
3 participants
@dcharkes @HosseinYousefi @coveralls