Skip to content

[native_assets_builder] Fix multiple invocations of the build runner #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2023
Merged

[native_assets_builder] Fix multiple invocations of the build runner #103

merged 1 commit into from
Jul 27, 2023

Conversation

dcharkes
Copy link
Collaborator

@dcharkes dcharkes commented Jul 27, 2023 •
edited
Loading

Closes #102.

@dcharkes dcharkes requested a review from HosseinYousefi July 27, 2023 16:24
@coveralls
Copy link

coveralls commented Jul 27, 2023 •
edited
Loading

Coverage Status

coverage: 98.649%. remained the same
when pulling a4dcbdc on fix-build-runner-multiple-calls
into 2598ac6 on main.

HosseinYousefi
HosseinYousefi approved these changes Jul 27, 2023
View reviewed changes
Copy link
Member

@HosseinYousefi HosseinYousefi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @dcharkes.

@auto-submit auto-submit bot merged commit f0dc3e9 into main Jul 27, 2023
@auto-submit auto-submit bot deleted the fix-build-runner-multiple-calls branch July 27, 2023 17:12
HosseinYousefi pushed a commit that referenced this pull request Nov 16, 2023
@dcharkes
[native_assets_builder] Fix multiple invocations of the build runner (#…
3f3d322 
…103)

Closes #102.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HosseinYousefi HosseinYousefi HosseinYousefi approved these changes

Assignees
No one assigned
Labels
autosubmit package:hooks_runner package:hooks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[native_assets_builder] Invoking more than one method on NativeAssetsBuildRunner
3 participants
@dcharkes @coveralls @HosseinYousefi