Skip to content

cleanup #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2017
Merged

cleanup #81

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/src/invocation_matcher.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ class _InvocationMatcher implements Matcher {

// Returns named arguments as an iterable of '<name>: <value>'.
static Iterable<String> _namedArgsAndValues(Invocation invocation) =>
invocation.namedArguments.keys.map/*<String>*/((name) =>
invocation.namedArguments.keys.map((name) =>
'${_symbolToString(name)}: ${invocation.namedArguments[name]}');

// This will give is a mangled symbol in dart2js/aot with minification
Expand Down
2 changes: 1 addition & 1 deletion lib/src/mock.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,7 +726,7 @@ typedef PostExpectation Expectation(x);
/// `when` or `verify` context (a call "for real"), Mockito will respond with
/// the stored canned response, if it can match the mock method parameters.
///
/// The response generators include [thenReturn], [thenAnswer], and [thenThrow].
/// The response generators include `thenReturn`, `thenAnswer`, and `thenThrow`.
Copy link
Member

@srawlins srawlins Oct 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The [] is how dartdoc links to other methods... why is this changed?

Copy link
Contributor Author

@a14n a14n Oct 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lint or hint :

[dart] Only reference in scope identifiers in doc comments.

Actually all those methods are on PostExpectation. Would you prefer [PostExpectation.thenThrow] ?

Copy link
Member

@srawlins srawlins Oct 24, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boo, we need this feature in markdown, in order for it to do what I'd want. Ok you're change is good then. Thanks!

///
/// See the README for more information.
Expectation get when {
Expand Down
2 changes: 1 addition & 1 deletion test/spy_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ void main() {

group("spy", () {
setUp(() {
mock = spy/*<RealClass>*/(new MockedClass(), new RealClass());
mock = spy(new MockedClass(), new RealClass());
});

test("should delegate to real object by default", () {
Expand Down