cleanup #81
Merged
cleanup #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srawlins
reviewed
Oct 24, 2017
| /// the stored canned response, if it can match the mock method parameters. | ||
| /// | ||
| /// The response generators include [thenReturn], [thenAnswer], and [thenThrow]. | ||
| /// The response generators include `thenReturn`, `thenAnswer`, and `thenThrow`. |
Member
There was a problem hiding this comment.
The [] is how dartdoc links to other methods... why is this changed?
Contributor
Author
There was a problem hiding this comment.
There's a lint or hint :
[dart] Only reference in scope identifiers in doc comments.
Actually all those methods are on PostExpectation. Would you prefer [PostExpectation.thenThrow] ?
Member
There was a problem hiding this comment.
Boo, we need this feature in markdown, in order for it to do what I'd want. Ok you're change is good then. Thanks!
mosuem
pushed a commit
to dart-lang/test
that referenced
this pull request
Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.