Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address a termination issue with GitHub alert syntax parsing #576

Merged
merged 3 commits into from
Jan 19, 2024

Conversation

devoncarew
Copy link
Member

  • address a termination issue with GitHub alert syntax parsing

When trying out the new alert syntax, it looks like the parsing never terminates - all the content after an alert is included in the alert.

cc @AlexV525


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

Copy link

Package publishing

Package Version Status Publish tag (post-merge)
package:markdown 7.2.1 ready to publish v7.2.1

Documentation at https://github.com/dart-lang/ecosystem/wiki/Publishing-automation.

@coveralls
Copy link

coveralls commented Jan 19, 2024

Pull Request Test Coverage Report for Build 7587761119

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 96.135%

Totals Coverage Status
Change from base Build 7551994459: 0.3%
Covered Lines: 1542
Relevant Lines: 1604

💛 - Coveralls

Copy link
Member

@srawlins srawlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These test cases look right to me; thanks!

lib/src/block_syntaxes/alert_block_syntax.dart Outdated Show resolved Hide resolved
@devoncarew devoncarew merged commit a8288ca into master Jan 19, 2024
8 checks passed
@devoncarew devoncarew deleted the bug_fix_alerts branch January 19, 2024 18:33
@AlexV525
Copy link
Contributor

@devoncarew Thanks for the fix!

@devoncarew
Copy link
Member Author

For sure! I think there's one remaining - though much more minor - issue. You can't currently have alerts w/ multiple paragraphs (filed as #577).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants