Fix canonicalization scoring when library shares package name #3551
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code and the comment for the code are opposite.
|
CC @goderbauer |
scheglov
approved these changes
Oct 25, 2023
| @@ -58,7 +58,7 @@ abstract mixin class Canonicalization | |||
| } | |||
|
|
|||
| // Give a big boost if the library has the package name embedded in it. | |||
| if (library.package.namePieces.intersection(library.namePieces).isEmpty) { | |||
| if (library.package.namePieces.intersection(library.namePieces).isNotEmpty) { | |||
There was a problem hiding this comment.
It is curious that there are no test changes.
There was a problem hiding this comment.
Oof I agree. There is minimal testing of this whole method. I will add a TODO and look into adding some unit tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code and the comment for the code are opposite.
Contribution guidelines:
dart format.Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.