Fix canonicalization scoring when library shares package name (#3551)

srawlins · web-flow · commit 967cc547adc7 · 2023-10-25T13:44:05.000-07:00
The code and the comment for the code are opposite.
diff --git a/lib/src/model/canonicalization.dart b/lib/src/model/canonicalization.dart
@@ -58,7 +58,7 @@ abstract mixin class Canonicalization
     }
 
     // Give a big boost if the library has the package name embedded in it.
-    if (library.package.namePieces.intersection(library.namePieces).isEmpty) {
+    if (library.package.namePieces.intersection(library.namePieces).isNotEmpty) {
       scoredCandidate._alterScore(1.0, _Reason.packageName);
     }
 

Original file line number	Diff line number	Diff line change
`@@ -58,7 +58,7 @@ abstract mixin class Canonicalization`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`// Give a big boost if the library has the package name embedded in it.`
`61`		`- if (library.package.namePieces.intersection(library.namePieces).isEmpty) {`
	`61`	`+ if (library.package.namePieces.intersection(library.namePieces).isNotEmpty) {`
`62`	`62`	`scoredCandidate._alterScore(1.0, _Reason.packageName);`
`63`	`63`	`}`
`64`	`64`