Skip to content

Update Highlight.js to 10.5.0 #2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2021

Conversation

parlough
Copy link
Member

@parlough parlough commented Dec 31, 2020

There's been a lot of fixes and improvements since the previous version.

Relating to Dart, the primary improvements are:

You can refer to the entire changelog here: https://github.com/highlightjs/highlight.js/blob/master/CHANGES.md

As for the increased file length, that is how they distribute their minified bundle now. The languages included are the same as listed in the README.

Corresponding pub-dev PR: dart-lang/pub-dev#4387

@google-cla google-cla bot added the cla: yes Google CLA check succeeded. label Dec 31, 2020
Copy link
Contributor

@jcollins-g jcollins-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed by checking a pack downloaded from highlightjs.org on 1/6/21 is byte for byte identical when the given languages are selected, and that highlighting still seems to work.

@jcollins-g jcollins-g merged commit 90489db into dart-lang:master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google CLA check succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants