Skip to content

Update README to talk about 'dart doc' #2898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 21, 2022
Merged

Update README to talk about 'dart doc' #2898

merged 7 commits into from
Jan 21, 2022

Conversation

mit-mit
Copy link
Member

@mit-mit mit-mit commented Jan 17, 2022

No description provided.

@mit-mit mit-mit requested a review from srawlins January 17, 2022 16:00
@srawlins
Copy link
Member

Looks like the tests need a tweak

@mit-mit
Copy link
Member Author

mit-mit commented Jan 20, 2022

You mean generally, or specifically for this PR?

@parlough
Copy link
Member

@mit-mit
Copy link
Member Author

mit-mit commented Jan 20, 2022

Ah, thanks Parker!

@parlough
Copy link
Member

parlough commented Jan 20, 2022

Seems a new diagnostic is being triggered with the latest dev builds as well. I can fix that is a separate PR (#2908)

@parlough
Copy link
Member

parlough commented Jan 20, 2022

The fix for the analyzer diagnostic has been merged in aeca535. If you merge the master branch in, I believe the build should pass now :)

@mit-mit
Copy link
Member Author

mit-mit commented Jan 21, 2022

@srawlins this is passing now

@srawlins srawlins merged commit 9ca6db5 into master Jan 21, 2022
@srawlins srawlins deleted the mit-mit-patch-1 branch January 21, 2022 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants