#3182. Update type_inheritance_A02/3_t*.dart #3193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eernstg
reviewed
May 21, 2025
There was a problem hiding this comment.
Looks good, with a couple of typos!
I was wondering why so many cases had been removed from the last 6 test libraries, but the reason is surely that they are concerned with the correct treatment of an augmentation with some wrong parts (namely: the type annotation), and this makes no sense in cases where the augmentation is an error in the first place (because variables can't be augmented any more). Added a note about this to the description of the PR.
LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t04_lib.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01.dart
Outdated
Show resolved
Hide resolved
sgrekhov
commented
May 21, 2025
LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t01.dart
Outdated
Show resolved
Hide resolved
LanguageFeatures/Augmentation-libraries/type_inheritance_A02_t04_lib.dart
Outdated
Show resolved
Hide resolved
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 23, 2025
2025-05-23 sgrekhov22@gmail.com dart-lang/co19#3182. Update augmenting_declarations_A04_*.dart (dart-lang/co19#3197) 2025-05-22 sgrekhov22@gmail.com dart-lang/co19#3182. Add application order tests (dart-lang/co19#3196) 2025-05-22 sgrekhov22@gmail.com dart-lang/co19#3182. Update augmenting_declarations_A01/02_*.dart tests (dart-lang/co19#3195) 2025-05-22 sgrekhov22@gmail.com dart-lang/co19#3182. Update type_inheritance_A04/5_t*.dart (dart-lang/co19#3194) 2025-05-22 sgrekhov22@gmail.com dart-lang/co19#3182. Update type_inheritance_A02/3_t*.dart (dart-lang/co19#3193) 2025-05-22 sgrekhov22@gmail.com dart-lang/co19#3057. Add "diamond" inheritance case to promotion via assignment tests (dart-lang/co19#3179) 2025-05-20 sgrekhov22@gmail.com dart-lang/co19#3182. Update type_inheritance_A01_* tests (dart-lang/co19#3191) 2025-05-20 sgrekhov22@gmail.com dart-lang/co19#3182. Update scoping tests (dart-lang/co19#3190) 2025-05-20 sgrekhov22@gmail.com dart-lang/co19#3182. Add enums and extensions tests (dart-lang/co19#3189) 2025-05-19 sgrekhov22@gmail.com dart-lang/co19#3182. Remove `augmented` expression tests (dart-lang/co19#3188) 2025-05-16 sgrekhov22@gmail.com dart-lang/co19#3057. Add promotion via type test tests. Check top and bottom types and Null (dart-lang/co19#3165) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: I0720274d910fb4e1385efeb038080995b35656f0 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430660 Reviewed-by: Alexander Thomas <athom@google.com> Reviewed-by: Erik Ernst <eernst@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The A02 tests are updated such that they satisfy the constraint that member implementations can be provided by an augmentation, but not overridden. The A03 tests are updated to test abstract instance variables (and several cases handling augmentation of other variables have been deleted because concrete variables cannot be augmented according to the new specification of augmentations).