#3057. Add promotion via type test tests. Check top and bottom types and Null #3165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

eernstg merged 5 commits into dart-lang:master from sgrekhov:co19-3057-58

May 16, 2025

Contributor

sgrekhov commented May 1, 2025

No description provided.


          dart-lang#3057. Add promotion via type test tests. Check top and bott…

7f7a6a5

…om types and Null

sgrekhov requested review from chloestefantsova and eernstg

May 1, 2025 10:26


          dart-lang#3057. Update promotion_via_type_test_A03_t12.dart according…

0bad1af

… to the spec

eernstg reviewed

View reviewed changes

Member

eernstg left a comment

Looks good! I'm suggesting that a couple of tests should be deleted, because they unfold some cases where the test is basically not possible to perform ("check how this promotion works, except that this promotion never occurs").

Also, a couple of typos.

TypeSystem/flow-analysis/promotion_via_type_test_A03_t04.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A03_t05.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A03_t05.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A03_t07.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A03_t09.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A04_t01.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A04_t02.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A04_t03.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A04_t04.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A04_t06.dart Show resolved Hide resolved


          Implement review recommendations

e79898f

sgrekhov commented

View reviewed changes

Contributor Author

sgrekhov left a comment

Updated, PTAL. Some tests deleted, some changed they expected result.

TypeSystem/flow-analysis/promotion_via_type_test_A03_t04.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A03_t05.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A03_t07.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A03_t09.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A04_t02.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A04_t03.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A04_t04.dart Outdated Show resolved Hide resolved

TypeSystem/flow-analysis/promotion_via_type_test_A04_t06.dart Show resolved Hide resolved

sgrekhov requested a review from eernstg

May 12, 2025 14:55

eernstg reviewed

View reviewed changes

Member

eernstg left a comment

Just one location in TypeSystem/flow-analysis/promotion_via_type_test_A03_t04.dart has a comment.

TypeSystem/flow-analysis/promotion_via_type_test_A03_t04.dart Outdated Show resolved Hide resolved


          Implement review recommendations

4f15aff

sgrekhov requested a review from eernstg

May 13, 2025 11:13

eernstg reviewed

View reviewed changes

Member

eernstg left a comment

Test t13 remains tricky because factor works in ways that may seem really confusing in special cases like top types.

TypeSystem/flow-analysis/promotion_via_type_test_A03_t13.dart Outdated Show resolved Hide resolved


          Update description in promotion_via_type_test_A03_t13.dart

245cd34

sgrekhov requested a review from eernstg

May 16, 2025 06:53

Member

eernstg commented May 16, 2025

Perhaps the update was not pushed?

Contributor Author

sgrekhov commented May 16, 2025

Really. Sorry. Pushed now.

eernstg approved these changes

View reviewed changes

Member

eernstg left a comment

LGTM, thanks!

Member

eernstg commented May 16, 2025

No. Problem. ;-D

eernstg merged commit eaa797d into dart-lang:master

2 checks passed

copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request


          [co19] Roll co19 to fb20d2b17e35c8fda50ca367c8efc4fb3dab040b

0ecaf30

2025-05-23 sgrekhov22@gmail.com dart-lang/co19#3182. Update augmenting_declarations_A04_*.dart (dart-lang/co19#3197)
2025-05-22 sgrekhov22@gmail.com dart-lang/co19#3182. Add application order tests (dart-lang/co19#3196)
2025-05-22 sgrekhov22@gmail.com dart-lang/co19#3182. Update augmenting_declarations_A01/02_*.dart tests (dart-lang/co19#3195)
2025-05-22 sgrekhov22@gmail.com dart-lang/co19#3182. Update type_inheritance_A04/5_t*.dart (dart-lang/co19#3194)
2025-05-22 sgrekhov22@gmail.com dart-lang/co19#3182. Update type_inheritance_A02/3_t*.dart (dart-lang/co19#3193)
2025-05-22 sgrekhov22@gmail.com dart-lang/co19#3057. Add "diamond" inheritance case to promotion via assignment tests (dart-lang/co19#3179)
2025-05-20 sgrekhov22@gmail.com dart-lang/co19#3182. Update type_inheritance_A01_* tests (dart-lang/co19#3191)
2025-05-20 sgrekhov22@gmail.com dart-lang/co19#3182. Update scoping tests (dart-lang/co19#3190)
2025-05-20 sgrekhov22@gmail.com dart-lang/co19#3182. Add enums and extensions tests (dart-lang/co19#3189)
2025-05-19 sgrekhov22@gmail.com dart-lang/co19#3182. Remove `augmented` expression tests (dart-lang/co19#3188)
2025-05-16 sgrekhov22@gmail.com dart-lang/co19#3057. Add promotion via type test tests. Check top and bottom types and Null (dart-lang/co19#3165)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: I0720274d910fb4e1385efeb038080995b35656f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/430660
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet