Skip to content

Conversation

zisoft
Copy link
Collaborator

@zisoft zisoft commented Jun 23, 2025

It turned out that using only the last part of the metadata tag name is not sufficient and in some cases it can be ambiguous.

In #18976 it breaks watermark settings for old edits.

Solution is to use the full metadata tag name for the variable name:

Bildschirmfoto 2025-06-23 um 13 28 54

This requires a documentation change as well, I will provide a PR on dtdocs for that.

fixes #18976

@TurboGit TurboGit added this to the 5.2.1 milestone Jun 23, 2025
@TurboGit TurboGit added bugfix pull request fixing a bug priority: high core features are broken and not usable at all, software crashes scope: DAM managing files, collections, archiving, metadata, etc. release notes: pending labels Jun 23, 2025
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the change I see that you're using the full tagname. Fine. But at the same time you've also removed the upper-case change, can you comment on that?

TIA.

@zisoft
Copy link
Collaborator Author

zisoft commented Jun 23, 2025

Yes, when importing images Xmp.dc.creator is read from the metadata.
Using uppercase variable names for the metadata tags won't match anymore.

Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see now, it works for me. Thanks.

@TurboGit TurboGit merged commit 163573a into darktable-org:master Jun 23, 2025
6 checks passed
@zisoft zisoft deleted the fix-metadata-variable-names branch June 24, 2025 04:52
@TurboGit
Copy link
Member

@zisoft : Can you draft an entry for the release notes please? TIA.

@zisoft
Copy link
Collaborator Author

zisoft commented Jul 18, 2025

Release notes:

The variable names for the metadata tags variables have been changed to the full case sensitive tag name to avoid ambiguity.

@TurboGit
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix pull request fixing a bug documentation-complete needed documentation is merged in dtdocs priority: high core features are broken and not usable at all, software crashes scope: DAM managing files, collections, archiving, metadata, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Xmp.dc.creator no longer supported?
3 participants