Skip to content

Conversation

@jenshannoschwalm
Copy link
Collaborator

@jenshannoschwalm jenshannoschwalm commented Nov 16, 2024

Handle drag and scroll in histogram in exposure sliders

Adjusting exposure and black level in the histogram/waveform/parade now supports all standard bauhaus features:

  • respect soft limits (override with ctrl+shift)
  • add speed modifier while dragging (ctrl for fine tuning) without jumping back to position at start of drag
  • reset exposure or blackpoint individually by double-clicking
  • right-click to get fine-tuning popup
  • show toast of slider value (just like other "shortcuts")

Cleanup exposure proxy

Since introduction of (*handle_event) in exposure proxy a number of proxy functions were superfluous
and thus have thus been removed.

Simplified code for checking and getting data from the exposure proxy for histogram visualizing and
getting black and exposure data.

Currently colorbalancergb makes use of blackpoint and exposure setting in the proxy module.
These data are only relevant is module is enabled.

Adjusting exposure and black level in the histogram/waveform/parade now supports all standard bauhaus features:
- respect soft limits (override with ctrl+shift)
- add speed modifier while dragging (ctrl for fine tuning) without jumping back to position at start of drag
- reset exposure or blackpoint individually by double-clicking
- right-click to get fine-tuning popup
- show toast of slider value (just like other "shortcuts")
@jenshannoschwalm jenshannoschwalm added feature: enhancement current features to improve scope: UI user interface and interactions scope: codebase making darktable source code easier to manage labels Nov 16, 2024
@jenshannoschwalm jenshannoschwalm added this to the 5.0 milestone Nov 16, 2024
@jenshannoschwalm
Copy link
Collaborator Author

Release note: The histogram-exposure interface now supports all standard bauhaus features.

Since introduction of (*handle_event) in exposure proxy a number of proxy functions were superfluous
and thus have thus been removed.

Simplified code for checking and getting data from the exposure proxy for histogram visualizing and
getting black and exposure data.

Currently colorbalancergb makes use of blackpoint and exposure setting in the proxy module.
These data are only relevant is module is enabled.
Copy link
Member

@TurboGit TurboGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice enhancement and clean-up, thanks!

@TurboGit TurboGit merged commit 4da816c into darktable-org:master Nov 16, 2024
6 checks passed
@jenshannoschwalm jenshannoschwalm deleted the exposure_proxy branch November 16, 2024 15:48
@jenshannoschwalm
Copy link
Collaborator Author

Nice enhancement

Done by our gtk wizard, not me ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation-complete needed documentation is merged in dtdocs feature: enhancement current features to improve scope: codebase making darktable source code easier to manage scope: UI user interface and interactions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants