Skip to content

Commit b3e02fd

Browse files
Only use enabled exposure for proxy
The exposure proxy found is only relevant if it's enabled. Relevant for: - histogram UI visualizing - currently colorbalancergb makes use of blackpoint and exposure setting in the proxy module. This should not happen if module is not enabled.
1 parent 8163c15 commit b3e02fd

File tree

1 file changed

+2
-6
lines changed

1 file changed

+2
-6
lines changed

src/develop/develop.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2873,12 +2873,8 @@ dt_dev_proxy_exposure_t *dt_dev_exposure_proxy_available(dt_develop_t *dev)
28732873
dt_dev_proxy_exposure_t *instance = &dev->proxy.exposure;
28742874
const dt_iop_module_t *exposure = instance && instance->module ? instance->module : NULL;
28752875

2876-
// note: can we do better here by testing the proxy module being enabled?
2877-
// this is relevant for
2878-
// - user feedback in histogram visualizing and
2879-
// - provided black and exposure data while extracting patches in colorbalancergb
2880-
// return exposure->enabled ? instance : NULL;
2881-
return exposure ? instance : NULL;
2876+
// only report back if proxy exposure module is anabled.
2877+
return exposure->enabled ? instance : NULL;
28822878
}
28832879

28842880
float dt_dev_exposure_get_exposure(dt_develop_t *dev)

0 commit comments

Comments
 (0)