-
Notifications
You must be signed in to change notification settings - Fork 219
Cleanup Spring Dependencies #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup Spring Dependencies #1334
Conversation
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Signed-off-by: siri-varma <siri.varma@outlook.com>
Signed-off-by: siri-varma <siri.varma@outlook.com>
Signed-off-by: siri-varma <siri.varma@outlook.com>
Signed-off-by: siri-varma <siri.varma@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siri-varma I've left some comments .. I do recommend not having the springframework.version managed in this way.. it will make it really hard to maintain.
Signed-off-by: siri-varma <siri.varma@outlook.com>
Signed-off-by: siri-varma <siri.varma@outlook.com>
Signed-off-by: siri-varma <siri.varma@outlook.com>
Signed-off-by: siri-varma <siri.varma@outlook.com>
Signed-off-by: sirivarma <siri.varma@outlook.com>
40660c4
to
508148c
Compare
@salaboy addressed all your comments. Thank you |
Signed-off-by: sirivarma <siri.varma@outlook.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@siri-varma the PR looks good, but could you please provide some details why this is needed so I have a better high level understanding.
@artur-ciocanu / @salaboy / @dapr-java-sdk-reveiwers PR is ready to be reviewed. Thank you |
Signed-off-by: sirivarma <siri.varma@outlook.com>
@artur-ciocanu / @dapr-java-sdk-reviewer / @salaboy Just a gentle reminder about this PR. Thank you |
@siri-varma could you address the conflicts and resend the PR. Thank you! |
@salaboy could you please take another look? From my perspective managing ALL the dependencies in a single place is a good idea. We used to have separate "code bases" for SDK and SDK tests, but almost a year ago I have added support for Maven profiles to be able to properly develop in an IDE. So to recap I think moving all the deps to parent POM will allow us to upgrade more easily and have better control over dependencies. |
Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
@artur-ciocanu resolved the comments. Thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for all the effort! 🙇
@salaboy could you please take a look? |
@artur-ciocanu @siri-varma and @dapr/maintainers-java-sdk I think this is good to merge.. we need to try to define when to upgrade to 3.4.5 of spring boot. I need to check the pipelines to make sure that we are testing with that version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
@dapr/maintainers-java-sdk please merge |
Thanks a lot everyone for the feedback and reviews |
@cicoyle / @artur-ciocanu This PR is ready to be merged. Created a separate issue to track the flaky build |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1334 +/- ##
============================================
+ Coverage 76.91% 78.17% +1.25%
- Complexity 1592 1831 +239
============================================
Files 145 223 +78
Lines 4843 5663 +820
Branches 562 601 +39
============================================
+ Hits 3725 4427 +702
- Misses 821 916 +95
- Partials 297 320 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Update CONTRIBUTING.md Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Fix spring Signed-off-by: siri-varma <siri.varma@outlook.com> * Add context Signed-off-by: siri-varma <siri.varma@outlook.com> * Phase 1 Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix spring Signed-off-by: siri-varma <siri.varma@outlook.com> * Add context Signed-off-by: siri-varma <siri.varma@outlook.com> * Phase 1 Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * move version Signed-off-by: sirivarma <siri.varma@outlook.com> * Fix pom Signed-off-by: sirivarma <siri.varma@outlook.com> * change version Signed-off-by: sirivarma <siri.varma@outlook.com> * remove unused Signed-off-by: siri-varma <siri.varma@outlook.com> * Address comments Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix test Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix test Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: sirivarma <siri.varma@outlook.com> --------- Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> Signed-off-by: siri-varma <siri.varma@outlook.com> Signed-off-by: sirivarma <siri.varma@outlook.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com>
* adding remote endpoint request from inside activity with retry Signed-off-by: salaboy <Salaboy@gmail.com> * adding retry with Microcks payloads Signed-off-by: salaboy <Salaboy@gmail.com> * fixing review comments Signed-off-by: salaboy <Salaboy@gmail.com> * chore: New task execution task id test (#1352) * chore: New task execution task id test test how taskExecutionTaskId can be used for idempotency Signed-off-by: Javier Aliaga <javier@diagrid.io> * chore: Clean up not used files Signed-off-by: Javier Aliaga <javier@diagrid.io> * docs: Task execution keys Signed-off-by: Javier Aliaga <javier@diagrid.io> * test: Modify unit tests Signed-off-by: Javier Aliaga <javier@diagrid.io> * Remove new lines Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com> --------- Signed-off-by: Javier Aliaga <javier@diagrid.io> Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com> * Revert "chore: New task execution task id test (#1352)" (#1389) This reverts commit 949584f. Signed-off-by: Javier Aliaga <javier@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com> * 1.5.5 (#1390) Signed-off-by: Cassandra Coyle <cassie@diagrid.io> Signed-off-by: salaboy <Salaboy@gmail.com> * Add Documentation for Conversation AI SDK (#1387) Signed-off-by: salaboy <Salaboy@gmail.com> * Cleanup Spring Dependencies (#1334) * Update CONTRIBUTING.md Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> * Fix spring Signed-off-by: siri-varma <siri.varma@outlook.com> * Add context Signed-off-by: siri-varma <siri.varma@outlook.com> * Phase 1 Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix spring Signed-off-by: siri-varma <siri.varma@outlook.com> * Add context Signed-off-by: siri-varma <siri.varma@outlook.com> * Phase 1 Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: siri-varma <siri.varma@outlook.com> * move version Signed-off-by: sirivarma <siri.varma@outlook.com> * Fix pom Signed-off-by: sirivarma <siri.varma@outlook.com> * change version Signed-off-by: sirivarma <siri.varma@outlook.com> * remove unused Signed-off-by: siri-varma <siri.varma@outlook.com> * Address comments Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix test Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix test Signed-off-by: siri-varma <siri.varma@outlook.com> * Fix things Signed-off-by: sirivarma <siri.varma@outlook.com> --------- Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> Signed-off-by: siri-varma <siri.varma@outlook.com> Signed-off-by: sirivarma <siri.varma@outlook.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Signed-off-by: salaboy <Salaboy@gmail.com> * network is needed Signed-off-by: salaboy <Salaboy@gmail.com> --------- Signed-off-by: salaboy <Salaboy@gmail.com> Signed-off-by: Javier Aliaga <javier@diagrid.io> Signed-off-by: artur-ciocanu <artur.ciocanu@gmail.com> Signed-off-by: Cassandra Coyle <cassie@diagrid.io> Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com> Signed-off-by: siri-varma <siri.varma@outlook.com> Signed-off-by: sirivarma <siri.varma@outlook.com> Co-authored-by: Javier Aliaga <javier@diagrid.io> Co-authored-by: Cassie Coyle <cassie.i.coyle@gmail.com> Co-authored-by: artur-ciocanu <artur.ciocanu@gmail.com> Co-authored-by: Siri Varma Vegiraju <siri.varma@outlook.com>
Description
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #940
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: