Migrate PubSub removing flaky test #1407
Conversation
|
@artur-ciocanu @cicoyle @salaboy Trying to move the following test to use Testcontainers I got a problem. java-sdk/sdk-tests/src/test/java/io/dapr/it/pubsub/http/PubSubIT.java Lines 571 to 572 in 3a8fd61 When running the test from I have 1 message with the first message containing 10 statuses. But using in-memory (Testcontainers) I have 10 messages and each one with 1 statuses. I would like to know if the |
sdk-tests/src/test/java/io/dapr/it/testcontainers/pubsub/http/TestPubSubApplication.java
Show resolved
Hide resolved
|
@mcruzdev I will try to review ASAP, but could you please check why the ITs are failing? |
It is another mapped flaky test |
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
|
Error, I need to change the assert... |
|
@mcruzdev could you please check what is wrong with the tests, I see this error: |
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Signed-off-by: Matheus Cruz <matheuscruz.dev@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1407 +/- ##
============================================
+ Coverage 76.91% 78.48% +1.56%
- Complexity 1592 1866 +274
============================================
Files 145 230 +85
Lines 4843 5790 +947
Branches 562 601 +39
============================================
+ Hits 3725 4544 +819
- Misses 821 925 +104
- Partials 297 321 +24 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
@mcruzdev the PR looks good. There are a few things that I think should be addressed:
- Please make sure that you use logger instead of System.out, I have tried to add comments to all the places, but please double check and make sure that we use logger everywhere
- The Dapr Jackson serialzer could replaced with
CustomizableObjectSerializerinstead of creating an inline class - I see that there are quite a few
Thread.sleep()invocations, I am wondering if there is a way to avoid them. If not I am OK with them.
Please take a look and let me know your thoughts.
| private static final Random RANDOM = new Random(); | ||
| private static final int PORT = RANDOM.nextInt(1000) + 8000; | ||
| private static final String APP_FOUND_MESSAGE_PATTERN = ".*application discovered on port.*"; | ||
|
|
There was a problem hiding this comment.
As far as I saw the mapper is used within the serializer so I think it should be moved to that class.
| @Test | ||
| @DisplayName("Should publish some payload types successfully") | ||
| public void shouldPublishSomePayloadTypesWithNoError() throws Exception { | ||
|
|
There was a problem hiding this comment.
I think we can extract serialized as a field variable, instead of instantiating in different tests.
| @Test | ||
| @DisplayName("Should publish various payload types to different topics") | ||
| public void testPubSub() throws Exception { | ||
|
|
There was a problem hiding this comment.
Same here, let's extract this
| client.publishEvent(PUBSUB_NAME, TOPIC_NAME, object).block(); | ||
| System.out.println("Published one object."); | ||
|
|
||
| client.publishEvent(PUBSUB_NAME, TYPED_TOPIC_NAME, object).block(); |
There was a problem hiding this comment.
Could we please use a logger instead of System.out
|
|
||
| //Publishing a cloud event. | ||
| client.publishEvent(new PublishEventRequest(PUBSUB_NAME, TOPIC_NAME, cloudEvent) | ||
| .setContentType("application/cloudevents+json")).block(); |
There was a problem hiding this comment.
Could we please use a logger instead of System.out
| public Mono<Void> handleMessageLongValues(@RequestBody(required = false) CloudEvent<PubSubIT.ConvertToLong> cloudEvent) { | ||
| return Mono.fromRunnable(() -> { | ||
| try { | ||
| Long message = cloudEvent.getData().getValue(); |
There was a problem hiding this comment.
Could we please use a logger instead of System.out
| @PostMapping(path = "/routeBulkSub") | ||
| public Mono<BulkSubscribeAppResponse> handleMessageBulk( | ||
| @RequestBody(required = false) BulkSubscribeMessage<CloudEvent<String>> bulkMessage) { | ||
| return Mono.fromCallable(() -> { |
There was a problem hiding this comment.
Could we please use a logger instead of System.out
|
|
||
| if (bulkMessage.getEntries().size() == 0) { | ||
| BulkSubscribeAppResponse response = new BulkSubscribeAppResponse(new ArrayList<>()); | ||
| responsesReceivedTestingTopicBulkSub.add(response); |
There was a problem hiding this comment.
Could we please use a logger instead of System.out
|
|
||
| List<BulkSubscribeAppResponseEntry> entries = new ArrayList<>(); | ||
| for (BulkSubscribeMessageEntry<?> entry: bulkMessage.getEntries()) { | ||
| try { |
There was a problem hiding this comment.
Could we please use a logger instead of System.out
| } | ||
| } | ||
| BulkSubscribeAppResponse response = new BulkSubscribeAppResponse(entries); | ||
| responsesReceivedTestingTopicBulkSub.add(response); |
There was a problem hiding this comment.
Could we please use a logger instead of System.out
Description
Use testcontainers for PubSub tests.
The main goal is to remove the following flaky test https://github.com/dapr/java-sdk/actions/runs/13773009141/job/38515768267#step:19:13432.
Closes one of the flaky test links related on the #1258 issue.
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: