Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: disable a12y checks for bots #58

Merged
merged 1 commit into from
Feb 18, 2024
Merged

ci: disable a12y checks for bots #58

merged 1 commit into from
Feb 18, 2024

Conversation

danvk
Copy link
Owner

@danvk danvk commented Feb 18, 2024

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Issue Reference

In order to be considered for merging, the pull request description must refer to a specific issue number. This is described in our Contributing Guide. We are closing this pull request for now but you can update the pull request description and reopen the pull request.
The check is looking for a phrase similar to: "Fixes #XYZ" or "Resolves #XYZ" where XYZ is the issue number that this PR is meant to address.

@danvk danvk changed the title tooling: disable a12y checks for bots ci: disable a12y checks for bots Feb 18, 2024
@danvk danvk merged commit 29c48a1 into main Feb 18, 2024
13 of 14 checks passed
@danvk danvk deleted the no-12y-bot branch February 18, 2024 13:34
JoshuaKGoldberg pushed a commit to JoshuaKGoldberg/create-typescript-app that referenced this pull request Feb 18, 2024
## PR Checklist

- [x] Addresses an existing open issue: fixes #1318
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

See linked issue. I set this up in my repo in
danvk/gravlax#58 following
typescript-eslint/typescript-eslint#8212. We can
wait for a few renovate bot updates on my repo to confirm that this has
the desired effect.

I added support for top-level `if` statements on jobs. It's possible to
skip an individual step (which is already supported) but skipping the
entire job seems more correct:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant