Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠 Tooling: Don't run compliance/accessibility checks on renovate PRs #1318

Closed
3 tasks done
danvk opened this issue Feb 18, 2024 · 5 comments · Fixed by #1319
Closed
3 tasks done

🛠 Tooling: Don't run compliance/accessibility checks on renovate PRs #1318

danvk opened this issue Feb 18, 2024 · 5 comments · Fixed by #1319
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request

Comments

@danvk
Copy link
Contributor

danvk commented Feb 18, 2024

Bug Report Checklist

  • I have tried restarting my IDE and the issue persists.
  • I have pulled the latest main branch of the repository.
  • I have searched for related issues and found none that matched my issue.

Overview

It would be nice if RenovateBot included alt text on its images, but that seems somewhat out of our hands.

For example:
#1316

I'd expect compliance and a12y checks to be skipped on Renovate PRs.

Additional Info

Related to #138 but not the same (that's about compliance checks preventing auto-merge).
@danvk danvk added the area: tooling Managing the repository's maintenance label Feb 18, 2024
@danvk
Copy link
Contributor Author

danvk commented Feb 18, 2024

Looks like you're ahead of me!

Issue: github/accessibility-alt-text-bot#45
Fix: typescript-eslint/typescript-eslint#8212

@danvk danvk mentioned this issue Feb 18, 2024
Merged
danvk added a commit to danvk/gravlax that referenced this issue Feb 18, 2024
@danvk
ci: disable a12y checks for bots (#58)
29c48a1 
## Overview

See JoshuaKGoldberg/create-typescript-app#1318

based on
typescript-eslint/typescript-eslint#8212
@danvk danvk mentioned this issue Feb 18, 2024
Merged
3 tasks
@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request labels Feb 18, 2024
@JoshuaKGoldberg
Copy link
Owner

Aside: I'd previously filed renovatebot/renovate#25714 on Renovate in November for more alt text:

Proposal: can we modify the alt text on that image to something just a bit more informative? Say:

- > [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)
+ > [![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

...and their images look like they've reverted back to the old alt text. Using danvk/gravlax#57 as an example:

<img src="..." alt="Mend Renovate" data-canonical-src="https://app.renovatebot.com/images/banner.svg" style="max-width: 100%;">

Filed renovatebot/renovate#27393.

JoshuaKGoldberg pushed a commit that referenced this issue Feb 18, 2024
@danvk
ci: do not run accessibility checks for bots (#1319)
218df8f 
## PR Checklist

- [x] Addresses an existing open issue: fixes #1318
- [x] That issue was marked as [`status: accepting
prs`](https://github.com/JoshuaKGoldberg/create-typescript-app/issues?q=is%3Aopen+is%3Aissue+label%3A%22status%3A+accepting+prs%22)
- [x] Steps in
[CONTRIBUTING.md](https://github.com/JoshuaKGoldberg/create-typescript-app/blob/main/.github/CONTRIBUTING.md)
were taken

## Overview

See linked issue. I set this up in my repo in
danvk/gravlax#58 following
typescript-eslint/typescript-eslint#8212. We can
wait for a few renovate bot updates on my repo to confirm that this has
the desired effect.

I added support for top-level `if` statements on jobs. It's possible to
skip an individual step (which is already supported) but skipping the
entire job seems more correct:
https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idif
@JoshuaKGoldberg
Copy link
Owner

@all-contributors please add @danvk for tool.

🤖 Beep boop! This comment was added automatically by all-contributors-auto-action.
Not all contributions can be detected from Git & GitHub alone. Please comment any missing contribution types this bot missed.
...and of course, thank you for contributing! 💙

@allcontributors allcontributors bot mentioned this issue Feb 18, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@JoshuaKGoldberg

I've put up a pull request to add @danvk! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

JoshuaKGoldberg pushed a commit that referenced this issue Feb 18, 2024
@allcontributors
docs: add danvk as a contributor for tool (#1320)
fa8828e 
Adds @danvk as a contributor for tool.

This was requested by JoshuaKGoldberg [in this
comment](#1318 (comment))

---------

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
@github-actions GitHub Actions
Copy link

🎉 This is included in version v1.57.9 🎉

The release is available on:

Cheers! 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: tooling Managing the repository's maintenance status: accepting prs Please, send a pull request to resolve this! type: feature New enhancement or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: do not run accessibility checks for bots danvk/create-typescript-app
2 participants
@danvk @JoshuaKGoldberg