Add integration test for ListIdentity

pack_test.go

@@ -212,7 +212,7 @@ func TestEncodeString(t *testing.T) {
 		return
 	}
 
-	want := "ASCIISTRING82,DINT,SINT[82]"
+	want := "STRING,DINT,SINT[82]"
 	if encoding != want {
 		t.Errorf("encoding mismatch. Got %v want %v", encoding, want)
 	}

tests/list_identity_test.go

@@ -0,0 +1,57 @@
+package gologix_tests
+
+import (
+	"testing"
+
+	"github.com/danomagnum/gologix"
+)
+
+func TestListIdentity(t *testing.T) {
+	// This test is a placeholder for the actual implementation
+	tcs := getTestConfig()
+	for _, tc := range tcs.ListIdentify {
+		t.Run(tc.Address, func(t *testing.T) {
+			client := gologix.NewClient(tc.Address)
+			err := client.Connect()
+			if err != nil {
+				t.Error(err)
+				return
+			}
+			defer func() {
+				err := client.Disconnect()
+				if err != nil {
+					t.Errorf("problem disconnecting. %v", err)
+				}
+			}()
+
+			identity, err := client.ListIdentity()
+			if err != nil {
+				t.Error(err)
+				return
+			}
+
+			if identity == nil {
+				t.Error("identity is nil")
+				return
+			}
+
+			if identity.ProductName != tc.ProductName {
+				t.Errorf("ProductName mismatch. Have %s. Want %s.", identity.ProductName, tc.ProductName)
+			}
+
+			version16 := uint16(tc.SoftwareVersionMinor)<<8 | uint16(tc.SoftwareVersionMajor)
+			if identity.Revision != version16 {
+				t.Errorf("Revision mismatch. Have %d. Want %d.", identity.Revision, version16)
+			}
+
+			if identity.SerialNumber != tc.SerialNumber {
+				t.Errorf("SerialNumber mismatch. Have %d. Want %d.", identity.SerialNumber, tc.SerialNumber)
+			}
+
+			if identity.ProductCode != tc.ProductCode {
+				t.Errorf("ProductCode mismatch. Have %d. Want %d.", identity.ProductCode, tc.ProductCode)
+			}
+
+		})
+	}
+}

tests/test_config template.json

@@ -10,6 +10,17 @@
     "SerialNumber": 1615551361,
     "ProductName": "1769-L35E/B LOGIX5335E"
     }
+  ],
+  "README_2": "The ListIdentify is used to identify the devices on the network.",
+  "Readme_3": "The program will cycle through them and test each one against the list identity tests.",
+  "ListIdentify": [
+    {
+      "Device_Address": "192.168.2.241",
+      "ProductCode": 65,
+      "SoftwareVersionMajor": 20,
+      "SoftwareVersionMinor": 19,
+      "SerialNumber": 1615551361,
+      "ProductName": "1769-L35E/B LOGIX5335E"
+    }
   ]
-
 }

tests/test_setup.go

@@ -15,6 +15,18 @@ type TestConfig struct {
 		SerialNumber         uint32 `json:"SerialNumber"`
 		ProductName          string `json:"ProductName"`
 	} `json:"PLC_List"`
+	ListIdentify []struct {
+		Address              string `json:"Device_Address"`
+		Vendor               uint16 `json:"Vendor"`
+		DeviceType           uint16 `json:"DeviceType"`
+		ProductCode          uint16 `json:"ProductCode"`
+		SoftwareVersionMajor uint16 `json:"SoftwareVersionMajor"`
+		SoftwareVersionMinor uint16 `json:"SoftwareVersionMinor"`
+		Status               uint16 `json:"Status"`
+		SerialNumber         uint32 `json:"SerialNumber"`
+		ProductName          string `json:"ProductName"`
+		State                uint8  `json:"State"`
+	} `json:"ListIdentify"`
 }
 
 func getTestConfig() TestConfig {